Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Pod .status.nodeInfo.kubeProxyVersion deprecation #43348

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Document Pod .status.nodeInfo.kubeProxyVersion deprecation #43348

merged 1 commit into from
Nov 28, 2023

Conversation

HirazawaUi
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
@HirazawaUi HirazawaUi mentioned this pull request Oct 6, 2023
Open
16 tasks
@sftim
Copy link
Contributor

sftim commented Oct 6, 2023

/retitle [WIP] [placeholder]: Document Pod .status.nodeInfo.kubeProxyVersion deprecation

@k8s-ci-robot k8s-ci-robot changed the title [placeholder]: add DisableNodeKubeProxyVersion feature gate doc [WIP] [placeholder]: Document Pod .status.nodeInfo.kubeProxyVersion deprecation Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@dipesh-rawat
Copy link
Member

@HirazawaUi Shouldn't we consider setting the dev-1.29 branch as the target branch instead of the main branch for this PR?

@sftim
Copy link
Contributor

sftim commented Oct 6, 2023

@HirazawaUi Shouldn't we consider setting the dev-1.29 branch as the target branch instead of the main branch for this PR?

We should.

/hold
OK to unhold once that's covered.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@HirazawaUi HirazawaUi changed the base branch from main to dev-1.29 October 6, 2023 15:56
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1571a07
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65413277559ce100082ea7fc

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language labels Oct 6, 2023
@dipesh-rawat
Copy link
Member

/remove-language id
/remove-area blog
/remove-area release-eng
/remove-sig release

(PR now targets dev-1.29 as expected)
/unhold

@k8s-ci-robot k8s-ci-robot removed language/id Issues or PRs related to Indonesian language do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshitasao
Copy link
Contributor

Hi @HirazawaUi , Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023.
Thank you!

@HirazawaUi HirazawaUi force-pushed the add-DisableNodeKubeProxyVersion-feature-gate branch from 85646d7 to 1571a07 Compare October 31, 2023 16:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@HirazawaUi HirazawaUi changed the title [WIP] [placeholder]: Document Pod .status.nodeInfo.kubeProxyVersion deprecation Document Pod .status.nodeInfo.kubeProxyVersion deprecation Nov 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
@HirazawaUi
Copy link
Contributor Author

HirazawaUi commented Nov 8, 2023 •
edited
Loading

@dipesh-rawat @sftim This PR is ready for review and the PR associated in k/k have been merged, would you mind taking a look?

@harshitasao
Copy link
Contributor

Hi, @HirazawaUi ! Kubernetes v1.29 Docs shadow here. Just a reminder that the deadline to have this PR reviewed and merged is Tuesday, 28 November. Let me know if you need any help!

@HirazawaUi
Copy link
Contributor Author

HirazawaUi commented Nov 26, 2023 •
edited
Loading

/assign @danwinship
May you review the documentation for deprecate kubeProxyVersion?
I apologize for informing you so close to the merger deadline.

@danwinship
Copy link
Contributor

lgtm though I'm not sure if we need to say more?

@katcosgrove
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb844b85604fec468ac159998d5052ac819596d5

@katcosgrove
Copy link
Contributor

/assign @natalisucks

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ff7614 into kubernetes:dev-1.29 Nov 28, 2023
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@danwinship danwinship

@natalisucks natalisucks

@katcosgrove katcosgrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
8 participants
@HirazawaUi @sftim @dipesh-rawat @k8s-ci-robot @harshitasao @danwinship @katcosgrove @natalisucks