-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new concept page for Sidecar containers #43346
Conversation
Is this mostly a move of the existing content to the new concept page? |
Yes, But there are few changes and addon points also. |
I think below two changes are required
|
Hi @tamilselvan1102,
Is this what you are talking about? If yes, it is already added to the PR. |
Updated, Thanks for remembering. |
/sig node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Here's some feedback.
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/label tide/merge-method-squash |
Relevant to #43610 |
a18c9db
to
131ae2b
Compare
LGTM for docs @kubernetes/sig-node-pr-reviews does this look right, now? |
Let me have a look today... |
LGTM, however with 1.29 sidecars are going to |
I'll check with release docs. Personally, I think this is better merged than not. |
/approve /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am fine with merging this into main as-is, then opening a PR against the dev-1.29 branch once I have frozen k/website. /hold cancel |
LGTM from #43346 (comment) /lgtm |
LGTM label has been added. Git tree hash: bd98d7ca54351db7ed66fa2617f182fa94176798
|
#44305 adapts that change for v1.29 |
@sftim,
WDYT? |
Does that text appear on the dev-1.29 branch? See https://deploy-preview-43082--kubernetes-io-vnext-staging.netlify.app/docs/ for the preview of that branch. |
Yes, It's there in dev-1.29 branch. |
OK. Would you be willing to send in a PR to fix that bug? You can branch from main shortly after the release that is scheduled for later today. |
Sure, I will work on it. |
Add a new concept page for Sidecar containers
Fixes #42762