Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] remove "O=system:masters" from "kube-apiserver-etcd-client".md #43171

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Sep 22, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2023
@k8s-ci-robot k8s-ci-robot requested review from kakts and ptux September 22, 2023 23:34
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 22, 2023
@netlify
Copy link

netlify bot commented Sep 22, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7dcb1c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/650e2452b6c42a000813296a
😎 Deploy Preview https://deploy-preview-43171--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks in sync with 'en' PR.
LGTM

Deploy Preview: deploy-preview-43171-/ja/certificates

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb60d610cbfe3060766934429641e1377fedaa4d

@atoato88
Copy link
Contributor

/lgtm

@atoato88
Copy link
Contributor

@nasa9084
Could you review this PR at your convenience?

@nasa9084
Copy link
Member

sorry for being late 🙇
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 490004b into kubernetes:main Oct 19, 2023
3 checks passed
@Arhell Arhell deleted the ja-remove branch October 19, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants