-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement By: Renaming 'ReadMes' to 'README' for Improved Clarity. #42982
Enhancement By: Renaming 'ReadMes' to 'README' for Improved Clarity. #42982
Conversation
Welcome @Rituraj-13! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localized README.md's
seems more appropriate to me than Localization of README.md's
Btw, I'm kind of getting some Hacktoberfest feel now 👀
I found |
Hello @Rituraj-13 brother, I appreciate your contribution, but maybe you got my words in wrong way. I mean |
/language en |
Thanks bro, for suggestions 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
LGTM label has been added. Git tree hash: 70394f8a8593032a9ebdd7a03bb22a55d41a75d3
|
/lgtm Need to trigger the CI again:
|
LGTM label has been added. Git tree hash: 2313c756c55878d75b2f1376ed4e814ef99a9948
|
Hey @windsonsea , |
Seems you run different command series and /lgtm is removed. /label tide/merge-method-squash |
Yeah, for some reason I couldn't make changes with those commands. So now, do I need to squash those 2 commits and again force push them ? |
/lgtm |
LGTM label has been added. Git tree hash: 2313c756c55878d75b2f1376ed4e814ef99a9948
|
I think "Localization" is likely correct in this instance as it is referring to specific localization teams. "Localization ReadMes" could probably be corrected to "Localization READMEs", and I'd also suggest taking the "``" out of the title. |
/area localization |
README.md
Outdated
@@ -182,7 +182,7 @@ If you need help at any point when contributing, the [New Contributor Ambassador | |||
| -------------------------- | -------------------------- | -------------------------- | | |||
| Arsh Sharma | @arsh | @RinkiyaKeDad | | |||
|
|||
## Localization `README.md`'s | |||
## Localized READMEs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Localized READMEs | |
## Localization READMEs |
README.md
Outdated
@@ -5,7 +5,7 @@ | |||
This repository contains the assets required to build the [Kubernetes website and documentation](https://kubernetes.io/). We're glad that you want to contribute! | |||
|
|||
- [Contributing to the docs](#contributing-to-the-docs) | |||
- [Localization ReadMes](#localization-readmemds) | |||
- [Localized READMEs](#localized-readmemds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Localized READMEs](#localized-readmemds) | |
- [Localization READMEs](#localization-readmes) |
/lgtm If someone from the localization team agrees I think this can go in. Thinking about it more, and not being able to read the majority of the localizations, if the non-english README pages are just a translation of this page, then “Localized README” is probably correct, but if there are region/language specific bits of content or info about the teams doing the localization, then the current “Localization READMEs” is probably correct. But that’s a lot of thinking for a small change 😅 Probably this should go in, and if it needs to be updated again we should package it with a more robust review/edit of the page. |
LGTM label has been added. Git tree hash: 64456623f6293da0e131a45a3e68f7f6550f1efc
|
/label tide/merge-method-squash |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubernetes#42982) * Fixed grammar and typo * Updated README.md * Changed Localized to Localization
A better title could have been: Reword 'ReadMes' to 'READMEs' |
Fixes issue - #42979
Made the required changes in README.md file .
Localization ReadMes
toLocalization READMEs
.