-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CloudDualStackNodeIPs to beta #42875
Merged
+8
−14
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,12 +65,12 @@ To configure IPv4/IPv6 dual-stack, set dual-stack cluster network assignments: | |
* kube-proxy: | ||
* `--cluster-cidr=<IPv4 CIDR>,<IPv6 CIDR>` | ||
* kubelet: | ||
* when there is no `--cloud-provider` the administrator can pass a comma-separated pair of IP | ||
addresses via `--node-ip` to manually configure dual-stack `.status.addresses` for that Node. | ||
If a Pod runs on that node in HostNetwork mode, the Pod reports these IP addresses in its | ||
`.status.podIPs` field. | ||
All `podIPs` in a node match the IP family preference defined by the `.status.addresses` | ||
field for that Node. | ||
* `--node-ip=<IPv4 IP>,<IPv6 IP>` | ||
* This option is required for bare metal dual-stack nodes (nodes that do not define a | ||
cloud provider with the `--cloud-provider` flag). If you are using a cloud provider | ||
and choose to override the node IPs chosen by the cloud provider, set the | ||
`--node-ip` option. | ||
* (The legacy built-in cloud providers do not support dual-stack `--node-ip`.) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure about wording here... but it seemed like it made more sense to describe the non-legacy-cloud-provider behavior first and then add a disclaimer about the legacy cloud providers, so we can just remove that sentence once they go away? |
||
|
||
{{< note >}} | ||
An example of an IPv4 CIDR: `10.244.0.0/16` (though you would supply your own address range) | ||
|
@@ -79,13 +79,6 @@ An example of an IPv6 CIDR: `fdXY:IJKL:MNOP:15::/64` (this shows the format but | |
address - see [RFC 4193](https://tools.ietf.org/html/rfc4193)) | ||
{{< /note >}} | ||
|
||
sftim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{{< feature-state for_k8s_version="v1.27" state="alpha" >}} | ||
|
||
When using an external cloud provider, you can pass a dual-stack `--node-ip` value to | ||
kubelet if you enable the `CloudDualStackNodeIPs` feature gate in both kubelet and the | ||
external cloud provider. This is only supported for cloud providers that support dual | ||
stack clusters. | ||
|
||
## Services | ||
|
||
You can create {{< glossary_tooltip text="Services" term_id="service" >}} which can use IPv4, IPv6, or both. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up dropping this part because it's not really about
kubelet --node-ip
(it's true whether the IPs were assigned by--node-ip
or by default) and because it's kind of obvious anyway... It was interesting to note these things at one point in the past when we had just fixed that behavior, but at this point, this is just how anyone would expect it to work.