Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update swap related description before installation #42820

Merged
merged 1 commit into from
Sep 15, 2023
Merged

update swap related description before installation #42820

merged 1 commit into from
Sep 15, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 1, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
@pacoxu pacoxu mentioned this pull request Sep 1, 2023
Open
@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e48941c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64f17f380a4b6a000793e921
😎 Deploy Preview https://deploy-preview-42820--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tengqm
tengqm reviewed Sep 1, 2023
View reviewed changes
content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md Outdated
* Swap disabled. You **MUST** disable swap in order for the kubelet to work properly.
* For example, `sudo swapoff -a` will disable swapping temporarily. To make this change persistent across reboots, make sure swap is disabled in config files like `/etc/fstab`, `systemd.swap`, depending how it was configured on your system.
* Swap configuration. The default behavior of a kubelet was to fail to start if swap memory was detected on a node. Swap has been supported since v1.22. And since v1.28, Swap is supported for cgroup v2 only; the NodeSwap feature gate of the kubelet is beta but disabled by default.
* You **MUST** disable swap if the kubelet is not properly configured to use swap. For example, `sudo swapoff -a` will disable swapping temporarily. To make this change persistent across reboots, make sure swap is disabled in config files like `/etc/fstab`, `systemd.swap`, depending how it was configured on your system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please 1) wrap the long lines manually for ease of change tracking and review, and localization; 2) avoid indentation by 4 spaces which may confuse the Markdown parser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks.

neolit123
neolit123 reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
this update has the correct details, but it forces us to update this description again after the fg is ga...and possibly another time.

can we just say "swap is condotionally supported. please read more here..." and link to some external page?

@pacoxu
Copy link
Member Author

pacoxu commented Sep 1, 2023

can we just say "swap is condotionally supported. please read more here..." and link to some external page?

Probably link to https://kubernetes.io/blog/2023/08/24/swap-linux-beta/.

@neolit123
Copy link
Member

can we just say "swap is condotionally supported. please read more here..." and link to some external page?

Probably link to https://kubernetes.io/blog/2023/08/24/swap-linux-beta/.

+1
let's see if sig docs agree

@tengqm
Copy link
Contributor

tengqm commented Sep 15, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c6eca723108909d68ec7c4d7f8422d3a1e6345db

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit b751746 into kubernetes:main Sep 15, 2023
5 checks passed
@windsonsea windsonsea mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacoxu @neolit123 @tengqm @k8s-ci-robot