Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize “Good practices for Kubernetes Secrets” to Japanese #42730

Merged
merged 23 commits into from
Oct 19, 2023

Conversation

bezalel-7
Copy link
Contributor

Hello!

issue: #42450
This pull request addresses issue #42450. It adds the translated content of the secrets-good-practices.md document from English to Japanese.

The purpose of this change is to make the Kubernetes documentation more accessible to Japanese-speaking users by providing a translated version of the "Kubernetes Secretsの適切な使用方法" document.

Thank you for reviewing this pull request!

The purpose of this commit is to make the Kubernetes documentation more accessible to Japanese-speaking users by providing a translated version of the "Kubernetes Secretsの適切な使用方法" document.

translated secrets-good-practices.md document from English to Japanese.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language labels Aug 26, 2023
@k8s-ci-robot k8s-ci-robot requested review from atoato88 and ptux August 26, 2023 09:08
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2023
@bezalel-7
Copy link
Contributor Author

/retitle Localize “Good practices for Kubernetes Secrets” to Japanese

@k8s-ci-robot
Copy link
Contributor

@bezalel-7: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Localize “Good practices for Kubernetes Secrets” to Japanese

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bezalel-7 bezalel-7 changed the title Create secrets-good-practices.md Localize “Good practices for Kubernetes Secrets” to Japanese Aug 26, 2023
@netlify
Copy link

netlify bot commented Aug 26, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fd27428
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6507455a1416470008907c06
😎 Deploy Preview https://deploy-preview-42730--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm tengqm changed the title Localize “Good practices for Kubernetes Secrets” to Japanese [ja] Localize “Good practices for Kubernetes Secrets” to Japanese Aug 27, 2023
@bezalel-7
Copy link
Contributor Author

@atoato88 this is the new pr with changes done only in ja section

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @nasa9084

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good translation!
Please refer to 翻訳スタイルガイド for notation guidelines.

bezalel-7 and others added 13 commits September 17, 2023 23:51
@t-inu
Copy link
Member

t-inu commented Sep 23, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3378a7a0cec60371faa6cb8a2b6029bd149cdc2f

@atoato88
Copy link
Contributor

/lgtm

For other reviewers, here is the updated page on the deploy preview site:

@bezalel-7
Copy link
Contributor Author

@Arhell can you review it

@Arhell
Copy link
Member

Arhell commented Sep 29, 2023

@Arhell can you review it

Hello, unfortunately I can’t, here is someone who can.
https://github.com/kubernetes/website/blob/main/OWNERS_ALIASES#L107

@bezalel-7
Copy link
Contributor Author

@nasa9084 can you please check this change out

@nasa9084
Copy link
Member

sorry for being late, LGTM~
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit d66891b into kubernetes:main Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants