Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl cli from 1.6 to 1.7 #4253

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Update kubectl cli from 1.6 to 1.7 #4253

merged 1 commit into from
Jul 3, 2017

Conversation

zhangxiaoyu-zidif
Copy link
Contributor

@zhangxiaoyu-zidif zhangxiaoyu-zidif commented Jul 2, 2017

Update kubectl cli from 1.6 to 1.7

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox


This change is Reviewable

Update kubectl cli from 1.6 to 1.7
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2017
@chenopis chenopis assigned chenopis and ahmetb and unassigned janetkuo and erictune Jul 3, 2017
@chenopis
Copy link
Contributor

chenopis commented Jul 3, 2017

I'm going to merge this for now, but we need to fix this upstream where this doc is autogenerated. @ahmetb Should we just change this to use the {{page.version}} variable?

@chenopis chenopis merged commit 2dc0134 into kubernetes:master Jul 3, 2017
@ahmetb
Copy link
Member

ahmetb commented Jul 3, 2017

@chenopis this should've been fixed with the update-imported-docs.sh. Did we run it for 1.7 release?

@zhangxiaoyu-zidif
Copy link
Contributor Author

@chenopis Hi, Andrew
After I check current version of kubernetes.github.io, I find about 30 files using kubectl v1.6. Should I update them all to v1.7?

@zhangxiaoyu-zidif zhangxiaoyu-zidif deleted the patch-4 branch July 3, 2017 22:27
@ahmetb
Copy link
Member

ahmetb commented Jul 4, 2017

@zhangxiaoyu-zidif if the file is saying "Auto generated" (just like the file you patched here did), please do not update them.

@chenopis
Copy link
Contributor

chenopis commented Jul 5, 2017

@ahmetb I don't think we did run update-imported-docs.sh for 1.7. Can you do that?

@ahmetb
Copy link
Member

ahmetb commented Jul 5, 2017

@chenopis will do. Do you mind drafting a quick doc on "how to make a docs release" with your experience so that we can add a checklist with this item?

@chenopis
Copy link
Contributor

chenopis commented Jul 5, 2017

@ahmetb Yup! Been working on that. Just invited you to the doc.

@ahmetb ahmetb mentioned this pull request Jul 5, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants