Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created issue-wrangler.md #42273

Merged
merged 7 commits into from
Oct 19, 2023
Merged

created issue-wrangler.md #42273

merged 7 commits into from
Oct 19, 2023

Conversation

haripriya9647
Copy link
Contributor

Added issue wrangler.md file

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @haripriya9647!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2023
@haripriya9647
Copy link
Contributor Author

Hello @divya-mohan0209 I have created a sample draft. Please let me know what improvements and expectations needs to be fulfilled

@netlify
Copy link

netlify bot commented Jul 28, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b3ee866
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652f7ef2febc3c000700aa00
😎 Deploy Preview https://deploy-preview-42273--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of changes. However, I'd like this to be more in alignment with the sections that the PR Wrangler file has. For example, Helpful GitHub queries, Helpful PROW commands, and when to close the issue would be better placed instead of the process implementation and the contributor hierarchy section.


<!-- overview -->

There are many issues that need triage, and in order to reduce our reliance on formal approvers or reviewers, we have introduced a new role to wrangle issues every week.The main responsibility of this role is to bridge the gap between organizational contributor and reviewer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend this to be phrased as below

Suggested change
There are many issues that need triage, and in order to reduce our reliance on formal approvers or reviewers, we have introduced a new role to wrangle issues every week.The main responsibility of this role is to bridge the gap between organizational contributor and reviewer.
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
This section covers the duties of an Issue Wrangler.

<!-- overview -->

There are many issues that need triage, and in order to reduce our reliance on formal approvers or reviewers, we have introduced a new role to wrangle issues every week.The main responsibility of this role is to bridge the gap between organizational contributor and reviewer.
This section covers the duties of a PR wrangler.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This section covers the duties of a PR wrangler.


Each day in a week-long shift as Issue Wrangler:

- Making sure the issue is worded and titled correctly to provide contributors with adequate information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Making sure the issue is worded and titled correctly to provide contributors with adequate information.
- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/docs/contribute/review/for-approvers/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, we might want to remove this from the PR Wrangler file to avoid overlap. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree!!

@haripriya9647
Copy link
Contributor Author

@divya-mohan0209 please have a look at these commits and suggest me improvements. I need some help regarding the GitHub queries. If you can assist me in what queries needs to be listed I will try elaborating based on your suggestions. Apart from this please let me know if you wish me to add the [note] in the issue wrangler page as well.


<!-- overview -->

In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the link may require updating.

Suggested change
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wranglers), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase it as below for more clarity

Suggested change
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler) and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.


Each day in a week-long shift as Issue Wrangler:

- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/docs/contribute/review/for-approvers/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
Copy link
Member

@dipesh-rawat dipesh-rawat Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github link appears to be directing to a 404 error page; an update might be needed.
(There is also option to use /docs/contribute/review/for-approvers/#triage-and-categorize-issues)

Suggested change
- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/docs/contribute/review/for-approvers/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.

@haripriya9647
Copy link
Contributor Author

Thanks @dipesh-rawat .I will add commit


<!-- overview -->

In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase it as below for more clarity

Suggested change
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler), formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wrangler) and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.

content/en/docs/contribute/participate/issue-wrangler.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/issue-wrangler.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/issue-wrangler.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/issue-wrangler.md Outdated Show resolved Hide resolved
However, encourage the user to provide more details or reopen the issue if they can reproduce it later.
- Having implemented the same functionality elsewhere. One can close this issue and direct user to the appropriate place.
- Feature requests that are not currently planned or aligned with the project's goals.
- If the assignee has not responded to comments or feedback in more than two weeks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very arbitrary & sketchy timeline.

@sftim @natalisucks @reylejano : Any thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave out a time frame to respond back
Anyone can assign themselves an issue. I don't think it's appropriate to close an issue if an assignee does not reply to comments or take action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-mohan0209 I am thinking of removing line 53. Is that okay or should I mention something else replacing this ??

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haripriya9647 : Please remove line 53.

@haripriya9647
Copy link
Contributor Author

@divya-mohan0209 waiting for your suggestions on this

@divya-mohan0209
Copy link
Contributor

@haripriya9647 : Thank you for bearing with the delay in my response. Please proceed with removal of line 53.

@haripriya9647
Copy link
Contributor Author

@divya-mohan0209 I have already removed line 53 in the latest commit. It seems like this pr is ready :)

- A minimum of 15 [non-trivial](https://www.kubernetes.dev/docs/guide/pull-requests/#trivial-edits) contributions to Kubernetes (of which a certain amount should be directed towards kubernetes/website).
- Performing the role in an informal capacity already

### Helpful [Prow commands](https://prow.k8s.io/command-help) for wranglers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra: mention /close not-planned (useful when closing an issue we won't work on and haven't fixed - for example, a duplicate bug report)

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


<!-- overview -->

In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wranglers),and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to reduce the burden on the [PR Wrangler](/docs/contribute/participate/pr-wranglers),and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Alongside the [PR Wrangler](/docs/contribute/participate/pr-wranglers),and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.

@haripriya9647
Copy link
Contributor Author

@sftim I have added commits as suggested. Please have a look

Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. /triage duplicate : When the issue is found to be a duplicate or subset of an existing open issue. It's also used oftenly before marking an issue for /close not-planned because of its duplication.
  2. /triage needs-information : When information provided by author is not sufficient to address the issue. It's also used before marking an issue for /close not-planned due to not sufficient information available.
  3. /priority backlog : For marking an issue with higher priority than normal issues due to some bug or backlog.

These labels are used oftenly, and so i thought of suggesting them to add here too. What do you think?

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some final feedback. Overall LGTM. Once this feedback is addressed, we can proceed for merging the PR.

Thank you @haripriya9647 for taking this up!


## Duties

Each day in a week-long shift as Issue Wrangler:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
Each day in a week-long shift as Issue Wrangler:
Each day in a week-long shift, the Issue Wrangler will be responsible for:

Each day in a week-long shift as Issue Wrangler:

- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
- Identifying whether the issue falls under the support category and assigning a "triage/accepted" status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Identifying whether the issue falls under the support category and assigning a "triage/accepted" status.


- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
- Identifying whether the issue falls under the support category and assigning a "triage/accepted" status.
- Ensuring the issue is tagged with the appropriate sig/area/kind labels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Ensuring the issue is tagged with the appropriate sig/area/kind labels.

- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
- Identifying whether the issue falls under the support category and assigning a "triage/accepted" status.
- Ensuring the issue is tagged with the appropriate sig/area/kind labels.
- Keeping an eye on stale & rotten issues within the kubernetes/website repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Keeping an eye on stale & rotten issues within the kubernetes/website repository.
- Keeping an eye on stale & rotten issues within the kubernetes/website repository.


Each day in a week-long shift as Issue Wrangler:

- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Triage and tag incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.
- Triaging and tagging incoming issues daily. See [Triage and categorize issues](https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for guidelines on how SIG Docs uses metadata.

- Identifying whether the issue falls under the support category and assigning a "triage/accepted" status.
- Ensuring the issue is tagged with the appropriate sig/area/kind labels.
- Keeping an eye on stale & rotten issues within the kubernetes/website repository.
- Maintenance of [Issues board](https://github.com/orgs/kubernetes/projects/72/views/1) would be nice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Maintenance of [Issues board](https://github.com/orgs/kubernetes/projects/72/views/1) would be nice
Maintenance of the [Issues board](https://github.com/orgs/kubernetes/projects/72/views/1).


Close issues when:

- When a similar issue is reported more than once, you'll first tag it as /triage duplicate; link it to the main issue & then close it. It is also advisable to direct the users to the original issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- When a similar issue is reported more than once, you'll first tag it as /triage duplicate; link it to the main issue & then close it. It is also advisable to direct the users to the original issue.
- A similar issue is reported more than once. You will first need to tag it as /triage duplicate; link it to the main issue & then close it. It is also advisable to direct the users to the original issue.

- When a similar issue is reported more than once, you'll first tag it as /triage duplicate; link it to the main issue & then close it. It is also advisable to direct the users to the original issue.
- It is very difficult to understand and address the issue presented by the author with the information provided.
However, encourage the user to provide more details or reopen the issue if they can reproduce it later.
- Having implemented the same functionality elsewhere. One can close this issue and direct user to the appropriate place.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Having implemented the same functionality elsewhere. One can close this issue and direct user to the appropriate place.
- The same functionality is implemented elsewhere. One can close this issue and direct user to the appropriate place.

- It is very difficult to understand and address the issue presented by the author with the information provided.
However, encourage the user to provide more details or reopen the issue if they can reproduce it later.
- Having implemented the same functionality elsewhere. One can close this issue and direct user to the appropriate place.
- Feature requests that are not currently planned or aligned with the project's goals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Feature requests that are not currently planned or aligned with the project's goals.
- The reported issue is not currently planned or aligned with the project's goals.

However, encourage the user to provide more details or reopen the issue if they can reproduce it later.
- Having implemented the same functionality elsewhere. One can close this issue and direct user to the appropriate place.
- Feature requests that are not currently planned or aligned with the project's goals.
- In cases where an issue appears to be spam and is clearly unrelated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- In cases where an issue appears to be spam and is clearly unrelated.
- If the issue appears to be spam and is clearly unrelated.

@Affan-7
Copy link
Contributor

Affan-7 commented Oct 2, 2023

Related to #41601

(Just for adding a link to the issue)


<!-- overview -->

Alongside the [PR Wrangler](/docs/contribute/participate/pr-wranglers),and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alongside the [PR Wrangler](/docs/contribute/participate/pr-wranglers),and formal approvers, and reviewers, members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.
Alongside the [PR Wrangler](/docs/contribute/participate/pr-wranglers), formal approvers, reviewers, and members of SIG Docs take week long shifts [triaging and categorising issues](/docs/contribute/review/for-approvers.md/#triage-and-categorize-issues) for the repository.

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

@haripriya9647 Mind give this another stab?

@haripriya9647
Copy link
Contributor Author

@divya-mohan0209 I have added all the commits as suggested. Please have a look.

@divya-mohan0209
Copy link
Contributor

Thank you @haripriya9647 for these changes and for your patience!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b85a3802c6f22a669257a99f3b99be3cf67c8676

@natalisucks
Copy link
Contributor

Great work @haripriya9647 and a big thank you to everyone who has contributed reviews. Lets get this live so we can start issue wrangling! 🚀 ✨
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f54227 into kubernetes:main Oct 19, 2023
3 checks passed
@haripriya9647 haripriya9647 deleted the pr branch December 16, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants