Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what's next for network plugin #42126

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

kundan2707
Copy link
Contributor

Updated what's next section in network plugin page

@k8s-ci-robot k8s-ci-robot requested review from dcbw and thockin July 21, 2023 17:17
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2023
@kundan2707
Copy link
Contributor Author

fixes: #42103

@kundan2707
Copy link
Contributor Author

/language en

@kundan2707
Copy link
Contributor Author

@dipesh-rawat resolved as per your suggestion.

@netlify
Copy link

netlify bot commented Jul 22, 2023

Pull request preview available for checking

Name Link
🔨 Latest commit d50d91f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6524ed2743324d00081a203f
😎 Deploy Preview https://deploy-preview-42126--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

incorporated review comments
@kundan2707 kundan2707 force-pushed the network_plugin_whats_next branch from 28d0460 to 448c2a5 Compare July 23, 2023 18:20
@kundan2707
Copy link
Contributor Author

@dipesh-rawat incorporated review comments

@kundan2707
Copy link
Contributor Author

@thockin @dcbw can you please have a look?

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 394bbf2e6e7d3d6e069f3c0bd8d700700075c3c6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87e29b2 into kubernetes:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants