Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connect-applications-service.md #42085

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Update connect-applications-service.md #42085

merged 2 commits into from
Oct 10, 2023

Conversation

AlexanderSerbul
Copy link
Contributor

We are talking about pods here, not about services yet.

@AlexanderSerbul
Update connect-applications-service.md
8face3d 
We are talking about pods here, not about services yet.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @AlexanderSerbul!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 19, 2023 10:17
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ad322d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64b7bffedcd5a100080cf4d9
😎 Deploy Preview https://deploy-preview-42085--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kundan2707
kundan2707 reviewed Jul 20, 2023
View reviewed changes
content/en/docs/tutorials/services/connect-applications-service.md
@@ -59,7 +59,7 @@ to make queries against both IPs. Note that the containers are *not* using port
the node, nor are there any special NAT rules to route traffic to the pod. This means
you can run multiple nginx pods on the same node all using the same `containerPort`,
and access them from any other pod or node in your cluster using the assigned IP
address for the Service. If you want to arrange for a specific port on the host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing one is correct

Copy link
Contributor Author

@AlexanderSerbul AlexanderSerbul Jul 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is "globally" correct. But locally in this paragraph we are speaking about pods yet, not services. We start to speak about services in the next chapter of the text.

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a38ae91bc5a9468b8bbb31add206af7d230e6195

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 329af06 into kubernetes:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@thockin thockin Awaiting requested review from thockin

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderSerbul @k8s-ci-robot @tengqm @kundan2707