-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post-release blog article about changes to Pod resources API #42041
Conversation
/hold I mis-clicked and did NOT upload as draft ( :( ) so WIP+hold to prevent merge |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sorry for too early assign, my bad. |
/unassign @onlydole just way too early |
/retitle [WIP] Add post-release blog article about changes to Pod resources API |
Hi Comms here for Release 1.28 we are checking in to see if you are going to complete this blog as it is due..? |
Hi, I'll be working on this blog post this week (week ending August 4) |
5f4a09d
to
b4a07b2
Compare
b4a07b2
to
3bd2759
Compare
the PR is now content-complete |
3bd2759
to
2b2e79f
Compare
content/en/blog/_posts/2023-MM-DD-kubelet-podresources-api-ga.md
Outdated
Show resolved
Hide resolved
4c03f38
to
a1de84f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
content/en/blog/_posts/2023-08-23-kubelet-podresources-api-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-23-kubelet-podresources-api-ga.md
Outdated
Show resolved
Hide resolved
a1de84f
to
fc84ca4
Compare
/hold need to fix the recommendations about the client package |
f6a2476
to
cbcaf55
Compare
/hold cancel In the last upload I made few minor fixes. I was looking for a good example of a client package, but I'm not yet in a position to recommend any, so I'm leaving this out from this blog post. The important part is that we really need to emphasize that reimplementing the client in a consumer project is still the recommended approach (!!!!), but this was already fixed in the past days. |
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
cbcaf55
to
b5f4cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b9845e5a1fcb8b0b300e35f5d51d564826a1a930
|
image: podresources-monitor:latest # just for an example | ||
volumeMounts: | ||
- mountPath: /host-podresources | ||
name: host-podresources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see usage of this with readOnly: true
. Since it is a Directory and not a socket, it should work OK and will limit the exposure. Changing it to readonly will require to add some explanation below explaining the difference between socket non-readonly and directory mount being readonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm certainly puzzled about how a read-only mount might let you make a read-write connection to a socket within that mount! That might separately merit an explanation in https://k8s.io/docs/concepts/storage/volumes/#hostpath
/hold |
LGTM for blog team. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SergeyKanzhelev, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
I'm intentionally covering multiple related enhancements with a single blog post.
Enhancements: