-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog for PersistentVolume last phase transition time #41981
Add blog for PersistentVolume last phase transition time #41981
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b1c6725
to
8bf7307
Compare
@jsafrane does this look good you you from technical side? |
1. Implement Retention Policies | ||
|
||
With the LastPhaseTransitionTime, administrators can now track when a PV was last used or transitioned to the "Released" phase. | ||
This information can be crucial for implementing retention policies to clean up resources that have been in the "Released" phase for a specific duration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show how crucial it is. "For example, it's trivial to write a script or a policy that deletes all PVs that are in Released phase for 1 week".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example added.
|
||
3. Produce Alerts and Metrics | ||
|
||
The LastPhaseTransitionTime can be utilized to produce alerts and metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need such metrics, we need code in KCM / PV controller that would emit them. I'm not sure it's a goal of this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it's not at this point - removing.
8bf7307
to
6fdb97a
Compare
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
4499f80
to
5a8d28b
Compare
lgtm from the sig-storage POV. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Release comms would need to assign a publication date for this. OK to unhold once that's happened and the article is updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback on the writing
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
2f08bb4
to
2d0e99b
Compare
See #41981 (review) We'll need release comms to assign a date; I'll nudge that team. |
Can we please put Aug 23 publication date? |
@bradmccoydev do you still want to include this article? We'd need a new date, maybe next week. |
@bradmccoydev @sftim Any updates on this one? |
We missed this as part of the post-release comms for v1.28 @RomanBednar would you like to write about the feature separately from post-release comms? That's what SIG Node did for https://kubernetes.io/blog/2023/09/13/userns-alpha/ |
@sftim Sure, does it mean just removing |
I'm afraid you'll also need to make some further (small) edits to make the article work right as a standalone piece. If you're not sure what to do, please make a start and a reviewer can provide feedback. |
2d0e99b
to
3b6bb3e
Compare
Looking at the SIG node article you linked above as an example it looks pretty similar, I'm not sure what further changes might be needed (apart from header change which I posted now). @xing-yang or @jsafrane Can you please take a look again? |
--- | ||
layout: blog | ||
title: "Persistent Volume Last Phase Transition Time" | ||
date: 2023-09-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a new publication date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pick a late-October weekday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New date is set, is Oct 23 ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks.
|
||
**Author:** Roman Bednář (Red Hat) | ||
|
||
In Kubernetes v1.28, we have introduced a new alpha feature that aims to improve PersistentVolume (PV) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Kubernetes v1.28 -> In the recent Kubernetes v1.28 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
|
||
## How to use it | ||
|
||
The `lastPhaseTransitionTime` field is alpha for Kubernetes v1.28, so it requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lastPhaseTransitionTime
field is alpha starting from Kubernetes v1.28, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thank you for the review and suggestions.
3b6bb3e
to
6d55c07
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I've suggested some tweaks to make.
/lgtm cancel
/hold cancel
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
--- | ||
layout: blog | ||
title: "Persistent Volume Last Phase Transition Time" | ||
date: 2023-09-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks.
content/en/blog/_posts/2023-08-15-pv-last-phase-transtition-time.md
Outdated
Show resolved
Hide resolved
67b1939
to
d9a9011
Compare
Feedbacks addressed, publish date confirmed. |
LGTM label has been added. Git tree hash: 499dbe5416b3c4c4d0eb5cca19e53e823c0d09f1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KEP: kubernetes/enhancements#3796