Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog for PersistentVolume last phase transition time #41981

Merged

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Jul 11, 2023

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from onlydole July 11, 2023 13:13
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d9a9011
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6523f2819ab0ba0008c31f73
😎 Deploy Preview https://deploy-preview-41981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from b1c6725 to 8bf7307 Compare August 1, 2023 14:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@RomanBednar RomanBednar changed the title WIP: Add blog for PersistentVolume last phase transition time Add blog for PersistentVolume last phase transition time Aug 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@RomanBednar
Copy link
Contributor Author

@jsafrane does this look good you you from technical side?

Comment on lines 31 to 34
1. Implement Retention Policies

With the LastPhaseTransitionTime, administrators can now track when a PV was last used or transitioned to the "Released" phase.
This information can be crucial for implementing retention policies to clean up resources that have been in the "Released" phase for a specific duration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show how crucial it is. "For example, it's trivial to write a script or a policy that deletes all PVs that are in Released phase for 1 week".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example added.


3. Produce Alerts and Metrics

The LastPhaseTransitionTime can be utilized to produce alerts and metrics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need such metrics, we need code in KCM / PV controller that would emit them. I'm not sure it's a goal of this feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it's not at this point - removing.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from 8bf7307 to 6fdb97a Compare August 2, 2023 10:09
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch 2 times, most recently from 4499f80 to 5a8d28b Compare August 3, 2023 09:10
@jsafrane
Copy link
Member

jsafrane commented Aug 7, 2023

lgtm from the sig-storage POV.

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Release comms would need to assign a publication date for this. OK to unhold once that's happened and the article is updated accordingly.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on the writing

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from xing-yang August 15, 2023 08:41
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from 2f08bb4 to 2d0e99b Compare August 15, 2023 09:38
@sftim
Copy link
Contributor

sftim commented Aug 15, 2023

See #41981 (review)

We'll need release comms to assign a date; I'll nudge that team.

@bradmccoydev
Copy link
Member

Can we please put Aug 23 publication date?

@sftim
Copy link
Contributor

sftim commented Aug 24, 2023

@bradmccoydev do you still want to include this article? We'd need a new date, maybe next week.

@RomanBednar
Copy link
Contributor Author

@bradmccoydev @sftim Any updates on this one?

@sftim
Copy link
Contributor

sftim commented Sep 19, 2023

We missed this as part of the post-release comms for v1.28

@RomanBednar would you like to write about the feature separately from post-release comms? That's what SIG Node did for https://kubernetes.io/blog/2023/09/13/userns-alpha/

@RomanBednar
Copy link
Contributor Author

@sftim Sure, does it mean just removing Kubernetes v1.28 from the heading (and slug), updating date and leaving the rest as it is?

@sftim
Copy link
Contributor

sftim commented Sep 24, 2023

@sftim Sure, does it mean just removing Kubernetes v1.28 from the heading (and slug), updating date and leaving the rest as it is?

I'm afraid you'll also need to make some further (small) edits to make the article work right as a standalone piece. If you're not sure what to do, please make a start and a reviewer can provide feedback.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from 2d0e99b to 3b6bb3e Compare September 26, 2023 11:06
@RomanBednar
Copy link
Contributor Author

I'm afraid you'll also need to make some further (small) edits to make the article work right as a standalone piece. If you're not sure what to do, please make a start and a reviewer can provide feedback.

Looking at the SIG node article you linked above as an example it looks pretty similar, I'm not sure what further changes might be needed (apart from header change which I posted now).

@xing-yang or @jsafrane Can you please take a look again?

---
layout: blog
title: "Persistent Volume Last Phase Transition Time"
date: 2023-09-20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a new publication date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pick a late-October weekday.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New date is set, is Oct 23 ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks.


**Author:** Roman Bednář (Red Hat)

In Kubernetes v1.28, we have introduced a new alpha feature that aims to improve PersistentVolume (PV)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Kubernetes v1.28 -> In the recent Kubernetes v1.28 release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.


## How to use it

The `lastPhaseTransitionTime` field is alpha for Kubernetes v1.28, so it requires
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lastPhaseTransitionTime field is alpha starting from Kubernetes v1.28, ...

Copy link
Contributor Author

@RomanBednar RomanBednar Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thank you for the review and suggestions.

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from 3b6bb3e to 6d55c07 Compare October 2, 2023 10:54
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I've suggested some tweaks to make.

/lgtm cancel
/hold cancel

---
layout: blog
title: "Persistent Volume Last Phase Transition Time"
date: 2023-09-20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from xing-yang October 5, 2023 22:11
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2023
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time branch from 67b1939 to d9a9011 Compare October 9, 2023 12:30
@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

Feedbacks addressed, publish date confirmed.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 499dbe5416b3c4c4d0eb5cca19e53e823c0d09f1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 14f30b5 into kubernetes:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

7 participants