Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redudant steps from instruction #41953

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Conversation

hasanrashid
Copy link
Contributor

This PR is intended to resolve issue 40377

Under the section "Securing the service" In https://kubernetes.io/docs/tutorials/services/connect-applications-service/#securing-the-service:

  1. A link to the default.conf in examples/staging/https-nginx/default.conf` is provided
  2. Redundant steps to create secrets and yml file are removed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp July 9, 2023 07:01
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 9, 2023 07:01
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 9, 2023
@netlify
Copy link

netlify bot commented Jul 9, 2023

Pull request preview available for checking

Name Link
🔨 Latest commit e728701
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6524f89569621700094a51c2
😎 Deploy Preview https://deploy-preview-41953--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Aug 13, 2023

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 13, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 42331fab9c0f01d893d321d03c1be5fbf6bd845f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 972a467 into kubernetes:main Oct 10, 2023
3 checks passed
Community-Programmer pushed a commit to Community-Programmer/website that referenced this pull request Oct 13, 2023
* Remove redudant steps from instruction

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Tim Bannister <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Change line 313, and add missing line

* Fix missing command end on line 313

* Update connect-applications-service.md

---------

Co-authored-by: Michael <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
aojea pushed a commit to aojea/website that referenced this pull request Oct 18, 2023
* Remove redudant steps from instruction

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Tim Bannister <[email protected]>

* Update content/en/docs/tutorials/services/connect-applications-service.md

Co-authored-by: Michael <[email protected]>

* Change line 313, and add missing line

* Fix missing command end on line 313

* Update connect-applications-service.md

---------

Co-authored-by: Michael <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Connecting Applications with Services" has a possibly erroneous section
5 participants