Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed -fs from troubleshooting command #4177

Merged
merged 10 commits into from
Jun 27, 2017
Merged

Removed -fs from troubleshooting command #4177

merged 10 commits into from
Jun 27, 2017

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Jun 23, 2017

Closes #1184

I tested the current docs command locally to verify that -fs silences errors. It's legit:

$ curl -fs -X PUT "http://${host}:${port}/v2/keys/_test"
$ 

After removing the -fs switch:

$ curl -X PUT "http://${host}:${port}/v2/keys/_test"
<html>
<head><title>400 Bad Request</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx/1.12.0</center>
</body>
</html>

This change is Reviewable

@zacharysarah zacharysarah self-assigned this Jun 23, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@chenopis chenopis self-assigned this Jun 23, 2017
@chenopis chenopis requested a review from mml June 23, 2017 20:22
@zacharysarah
Copy link
Contributor Author

Formerly #4159, reopened as a new PR for cleaner commit history.

@chenopis
Copy link
Contributor

Ok, I checked this. /lgtm

@chenopis chenopis removed the request for review from mml June 27, 2017 23:40
@chenopis chenopis merged commit 37311bc into kubernetes:master Jun 27, 2017
chenopis added a commit that referenced this pull request Jun 27, 2017
chenopis added a commit that referenced this pull request Jun 27, 2017
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Removed -fs from troubleshooting command

* Add YAML file for configmaps in concepts

* Add new topic for configmaps in concepts

* Add configuration entry for understanding configmaps

* Move Understanding Configmaps to a separate concept file

* Revert "Move Understanding Configmaps to a separate concept file"

This reverts commit 71bd80d.

* Revert "Add configuration entry for understanding configmaps"

This reverts commit c27fc13.

* Revert "Add new topic for configmaps in concepts"

This reverts commit 3d535f5.

* Revert "Add YAML file for configmaps in concepts"

This reverts commit 8ecabd6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants