Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introducing Sleep Action for PreStop Hook #41730

Closed
wants to merge 1 commit into from

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Jun 22, 2023

This is a place holder for KEP 3960 kubernetes/enhancements#3960 (comment)

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mikedanese June 22, 2023 09:17
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from onlydole June 22, 2023 09:17
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bradtopol for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2023
@sftim
Copy link
Contributor

sftim commented Aug 10, 2023

/hold

This isn't part of Kubernetes v1.28

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@gracenng
Copy link
Member

/milestone clear

@k8s-ci-robot
Copy link
Contributor

@gracenng: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone clear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AxeZhan
Copy link
Member Author

AxeZhan commented Aug 11, 2023

This kep will be tracked in 1.29, I'll create another one in the next release.

@AxeZhan
Copy link
Member Author

AxeZhan commented Aug 11, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@AxeZhan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants