Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building for deploy, limit GOMAXPROCS #41301

Conversation

sftim
Copy link
Contributor

@sftim sftim commented May 24, 2023

Copy the approach that we already use for Netlify deploy previews (added in PR #41142).

It would be OK to drop this once Golang is better able to work with CFS, or if Hugo includes detection for the cgroup CPU limit.

Copy the approach that we already use for Netlify deploy previews.

It would be OK to drop this once Golang is better able to work with
CFS, or if Hugo includes detection for the cgroup CPU limit.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3724386
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/646de98a29bba9000815bd30
😎 Deploy Preview https://deploy-preview-41301--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented May 24, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@reylejano
Copy link
Member

thank you
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e4b78a33f51f8b3623ebc6a287b9395eda436e5

@k8s-ci-robot k8s-ci-robot merged commit b9584fe into kubernetes:main May 24, 2023
@sftim sftim deleted the 20230524_limit_max_goroutines_for_site_deploy branch September 23, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants