Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] fix/ko-replace-all-references-storage-to-k8s #41281

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented May 23, 2023

Re: pull request #41078

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language labels May 23, 2023
@k8s-ci-robot k8s-ci-robot requested review from pjhwa and yoonian May 23, 2023 11:35
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2023
@9bany 9bany changed the title fix/ko-replace-all-references-storage-to-k8s [ko] fix/ko-replace-all-references-storage-to-k8s May 23, 2023
@rjsadow
Copy link
Contributor

rjsadow commented May 23, 2023

/ok-to-test
/lgtm
Thanks @9bany

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3f3a51ff29094274c1d9da5ee45dde12ee785d2

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit cbcf4e7
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/646ca512a761e20009052a32
😎 Deploy Preview https://deploy-preview-41281--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rjsadow
Copy link
Contributor

rjsadow commented May 23, 2023

/assign @gochist
/assign @jongwooo

@rjsadow rjsadow removed their assignment May 23, 2023
@gochist
Copy link
Member

gochist commented May 24, 2023

Thank you @9bany @rjsadow !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74c2a2c into kubernetes:dev-1.26-ko.1 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants