Reorganise part of the Service concept #40671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
386e16f to
177aa99
Compare
sftim
commented
Apr 13, 2023
Comment on lines
1171
to
1168
| {{< note >}} | ||
| This section is indebted to the [Kubernetes Tips - Part | ||
| 1](https://akomljen.com/kubernetes-tips-part-1/) blog post from [Alen Komljen](https://akomljen.com/). | ||
| {{< /note >}} |
There was a problem hiding this comment.
Dropping this mention after ≅ 5 years; the page has changed quite a bit since then.
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
177aa99 to
11df9ef
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 72986ae76ef0b2635f6e97d83c3fd982b5aab45d
|
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
11df9ef to
bd9f1a1
Compare
k8s-ci-robot
removed
the
lgtm
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
bd9f1a1 to
26cd69f
Compare
tengqm
reviewed
May 10, 2023
| either: | ||
|
|
||
| * DNS CNAME records for [`type: ExternalName`](#externalname) Services. | ||
| * DNS A / AAAA records for all IP addresses of the Service's ready endpoints, |
There was a problem hiding this comment.
Can you clarify how a Service gets its endpoints if it has no selector?
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3958bea9cb2eb66c6611ecea69c88690a0651afc
|
|
@sftim Can you send another commit? |
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
26cd69f to
22cdf9f
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
22cdf9f to
5fc2336
Compare
sftim
force-pushed
the
20230413_revise_service_concept_partially
branch
from
5fc2336 to
2516bc2
Compare
k8s-ci-robot
removed
the
size/L
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move two sections (Headless Services, Discovering Services) within the Service concept.
Split out from #30817. View that PR, or #38563, to see these changes in context. They might not make much sense in isolation. In the bigger context, the change allows these details to appear after explaining the 4 types of Service.
These changes are an enabling reorganization to make other parts of #30817 easier to review.