-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl docs/Explain beta docs #40068
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @alexzielenski, when you're ready, populate your placeholder PR with feature documentation and change the state of the PR from draft to ready for review. The official Docs deadline for PRs to be ready for review is tomorrow, March 21st. All docs PRs must be reviewed and ready to merge by April 4th. To mark a pull request as ready for review, navigate to the merge box and click Ready for review. Regarding the content of your documentation, do your best to describe your feature and how to use it. If you need help structuring your documentation, ask in the #sig-docs Slack channel. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. |
d981219
to
7d8d563
Compare
I've ran the commands to regenerate the kubectl reference. it has a lot of updates but the new flags for explain are not included. Still looking into it. Will ask on slack for help. Marking as ready for review in the meantime in case someone has some thoughts. |
@alexzielenski You will have to update the If this is targeting 1.27, you will have to target |
@alexzielenski Did you get a chance to make @tengqm suggested changes? |
Unfortunately I'm still having trouble with it.
|
7d8d563
to
7168071
Compare
@tengqm @sftim @reylejano do you know how to correct the error above? |
Looks like you're bringing changes from the |
@alexzielenski could you try what @reylejano suggested when you have a moment? |
@mickeyboxell I've done that, yeah but I don't think changing the targeted PR branch fixes anything since it was already based on dev-1.27, the script still fails. |
/sig cli |
/hold I agree with the intent of this PR. You are welcome to unhold it once it has an LGTM that you are happy with @alexzielenski (any org member can LGTM, so you might get a review that says LGTM even before the last bug you're aware of is actually dealt with). |
PS. Would be nice to record that intent in the PR description. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 4f1ece35f7eeab360f06282f67315e88d686508c
|
@alexzielenski If you are comfortable removing the hold from this PR, we can get it merged. |
We may have to compare with a kubectl ref docs generation after the 1.27 release /unhold |
Regenerates kubectl documentation to include quite a few missed changes, as well as the new
explain
functionality.