Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3488 ValidatingAdmissionPolicy post-1.27 update #40054

Merged
merged 1 commit into from
Apr 4, 2023
Merged

KEP-3488 ValidatingAdmissionPolicy post-1.27 update #40054

merged 1 commit into from
Apr 4, 2023

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Mar 16, 2023 •
edited
Loading

This PR covers the following new features of ValidatingAdmissionPolicy

  • messageExpression
  • type checking

This PR is ready for review.

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3488-cel-admission-control

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@jiahuif jiahuif changed the title [WIP][Placeholder] ValidatingAdmissionPolicy [WIP][Placeholder] KEP-3488 ValidatingAdmissionPolicy Mar 16, 2023
@sftim
Copy link
Contributor

sftim commented Mar 16, 2023

/sig api-machinery
/sig auth

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Mar 16, 2023
@sftim
Copy link
Contributor

sftim commented Mar 16, 2023

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 16, 2023
@liggitt liggitt mentioned this pull request Mar 16, 2023
Open
16 tasks
@mickeyboxell
Copy link
Contributor

mickeyboxell commented Mar 21, 2023 •
edited
Loading

Hi @jiahuif 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required the SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@jiahuif jiahuif changed the title [WIP][Placeholder] KEP-3488 ValidatingAdmissionPolicy KEP-3488 ValidatingAdmissionPolicy post-1.27 update Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@jiahuif jiahuif force-pushed the feature/validating-admission-policy/post-1.27 branch 6 times, most recently from 874ce4d to 6af5478 Compare March 21, 2023 20:13
jpbetz
jpbetz suggested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things, then LGTM.

content/en/docs/reference/access-authn-authz/validating-admission-policy.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md Show resolved Hide resolved
@jiahuif jiahuif force-pushed the feature/validating-admission-policy/post-1.27 branch 4 times, most recently from 48f519f to c88f863 Compare March 22, 2023 00:01
@jpbetz
Copy link
Contributor

jpbetz commented Mar 22, 2023

/lgtm
For technical content

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 823464a06c7a6756f8d5eb985dfd47e0b8a078a2

@jpbetz
Copy link
Contributor

jpbetz commented Mar 22, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2023
@jiahuif jiahuif force-pushed the feature/validating-admission-policy/post-1.27 branch from c88f863 to 5a500dc Compare March 22, 2023 20:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz March 22, 2023 20:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Mar 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f468ec274d0475f67575c2aa97b1cfe820aa92c

@jiahuif
Copy link
Member Author

jiahuif commented Mar 28, 2023

Hi @mickeyboxell ! Now that this PR has the technical review, could you give it a pass to merge it? Thank you.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1ac2c92
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642afff346204c000815cedf

@jiahuif jiahuif force-pushed the feature/validating-admission-policy/post-1.27 branch from 930632c to 1df930d Compare April 3, 2023 16:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@jiahuif jiahuif force-pushed the feature/validating-admission-policy/post-1.27 branch from 1df930d to 0d862b9 Compare April 3, 2023 16:38
@netlify
Copy link

netlify bot commented Apr 3, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0d862b9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642b00fff218aa0007d38b70

@jpbetz
Copy link
Contributor

jpbetz commented Apr 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84a78ddb51e0f1287b62659ae999b1a683c66464

@jpbetz
Copy link
Contributor

jpbetz commented Apr 3, 2023

/approve

@jiahuif
Copy link
Member Author

jiahuif commented Apr 3, 2023 •
edited
Loading

@tengqm Thank you very much for your review. I've added and squashed all suggestions.

The PR was rebased due to a merge conflict. Could you take another look during your uptime? Thank you.

@reylejano
Copy link
Member

Thank you for replying to comments
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit dfdb707 into kubernetes:dev-1.27 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@jpbetz jpbetz jpbetz approved these changes

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
7 participants
@jiahuif @sftim @mickeyboxell @jpbetz @k8s-ci-robot @reylejano @tengqm