Add docs for VolumeManager reconstruction after kubelet restart #40038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
8 tasks
|
Please also review release-note in kubernetes/kubernetes#115268, that's the other place where we warn that any issues with kubelet startup could be caused by this feature. |
|
/retitle Add docs for VolumeManager reconstruction after kubelet restart |
k8s-ci-robot
changed the title
sftim
reviewed
Mar 16, 2023
Comment on lines
630
to
633
| - `NewVolumeManagerReconstruction`: Enables improved discovery of mounted volumes during kubelet | ||
| startup. Since this code has been significantly refactored, we allow to opt-out in case kubelet | ||
| gets stuck at the startup or is not unmounting volumes from terminated Pods. Note that this | ||
| refactoring was behind `SELinuxMountReadWriteOncePod` alpha feature gate in Kubernets 1.25. |
There was a problem hiding this comment.
- We should revise the
SELinuxMountReadWriteOncePoddescription too, then.- We can backport a change to 1.25 and 1.26 docs to explain that the feature gate behavior partly moves to
NewVolumeManagerReconstruction
- We can backport a change to 1.25 and 1.26 docs to explain that the feature gate behavior partly moves to
- “Kubernets” is a typo
|
/sig node |
k8s-ci-robot
added
the
sig/node
|
/sig storage |
k8s-ci-robot
added
the
sig/storage
jsafrane
force-pushed
the
volume-reconstruction
branch
from
0d7b014 to
cfde821
Compare
sftim
reviewed
Mar 20, 2023
jsafrane
force-pushed
the
volume-reconstruction
branch
from
cfde821 to
7eefbb8
Compare
k8s-ci-robot
added
size/S
sftim
reviewed
Mar 20, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 83a00fb782c443b993b0233bdda1af603dac598e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for
NewVolumeManagerReconstructionfeature gate. This feature should be invisible to users - kubelet does the same thing as before, only in a different order at the startup. It's behind a feature gate to allow opt-out in case it's buggy.KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3756-volume-reconstruction
Enhancement issue: kubernetes/enhancements#3756