Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update for KEP-3352 Aggregated Discovery #40024

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Doc update for KEP-3352 Aggregated Discovery #40024

merged 3 commits into from
Mar 31, 2023

Conversation

Jefftree
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2023
@Jefftree Jefftree changed the title placeholder [WIP] Placeholder for doc update for KEP-3352 Aggregated Discovery Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@Jefftree Jefftree mentioned this pull request Mar 15, 2023
Closed
11 tasks
@mickeyboxell
Copy link
Contributor

mickeyboxell commented Mar 20, 2023 •
edited
Loading

Hi @Jefftree, when you're ready, populate your placeholder PR with feature documentation and change the state of the PR from draft to ready for review. The official Docs deadline for PRs to be ready for review is tomorrow, March 21st. All docs PRs must be reviewed and ready to merge by April 4th. To mark a pull request as ready for review, navigate to the merge box and click Ready for review.

Regarding the content of your documentation, do your best to describe your feature and how to use it. If you need help structuring your documentation, ask in the #sig-docs Slack channel. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 21, 2023
@Jefftree Jefftree force-pushed the agg-discovery-doc branch from 123de2f to 0932a5c Compare March 21, 2023 14:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@Jefftree Jefftree changed the title [WIP] Placeholder for doc update for KEP-3352 Aggregated Discovery Doc update for KEP-3352 Aggregated Discovery Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@Jefftree Jefftree force-pushed the agg-discovery-doc branch from 8f8dcdd to 2af591d Compare March 21, 2023 14:44
@mickeyboxell
Copy link
Contributor

@Jefftree I see you added content to the docs. If this is ready for review, please change the state of the PR from draft to ready for review.

@Jefftree Jefftree force-pushed the agg-discovery-doc branch from 2af591d to 9d15d73 Compare March 21, 2023 22:34
@Jefftree Jefftree force-pushed the agg-discovery-doc branch from 9d15d73 to b677f2a Compare March 27, 2023 17:05
@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 4967f9c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6426567c59fd1200085b326b

@Jefftree
Copy link
Member Author

/cc @seans3 @alexzielenski
/assign @apelisse

@apelisse
Copy link
Member

apelisse commented Mar 27, 2023 •
edited
Loading

Looks good, thanks. Technical LGTM

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@mickeyboxell
Copy link
Contributor

@Jefftree would you mind rebasing when you get the chance?

@Jefftree Jefftree force-pushed the agg-discovery-doc branch from b677f2a to dd1c643 Compare March 28, 2023 22:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00546cdd580a1bc7f2dc86c84f1af6266e7c496e

@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 17ad96c into kubernetes:dev-1.27 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@seans3 seans3 Awaiting requested review from seans3

Assignees

@apelisse apelisse

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@Jefftree @mickeyboxell @apelisse @tengqm @k8s-ci-robot