CVE feed cleanup on i18n data and shortcode compliance check #39727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previsouly we were using two data items:
```toml
[cve_table_date_before]
other = "(last updated: "
[cve_table_date_after]
other = ")"
```
Which was simplified, using printf, to:
```toml
[cve_table_date_format_string]
other = "(last updated: %s)"
```
This is related to the following discussion
kubernetes#38579 (comment)
Previously it would cause the build to fail, which could lead to confusing situation since the CVE feed comes from outside of the website and could break the workflow. See related discussion: kubernetes#38579 (comment)
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
sig/security
k8s-ci-robot
added
the
size/S
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 92ffacdd8bd2b166028cbbea608028af46b637fa
|
k8s-ci-robot
added
the
approved
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the two issues discussed in #38579, see the following list:
Commit: 3d850f6
Commit: aa9f17e
/cc @kbhawkey
/cc @PushkarJ @nehaLohia27
/kind cleanup
/sig security