-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace docker run for running etcdctl command with just etcdctl #39149
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
/label tide/merge-method-squash |
LGTM label has been added. Git tree hash: 7a3fc39a04099d39c9c74acd10c43e9bba52b6f1
|
content/en/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm.md
Show resolved
Hide resolved
/lgtm |
LGTM label has been added. Git tree hash: b91cdf8873dfaa3790cdfed60b064445c0a03c79
|
1 similar comment
LGTM label has been added. Git tree hash: b91cdf8873dfaa3790cdfed60b064445c0a03c79
|
content/en/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @sftim can you please review this PR? |
/lgtm |
LGTM label has been added. Git tree hash: dbe99f06fe210fb283962d6d5adf6d7cfa5f16f4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ernetes#39149) * replace docker run for running etcdctl command with just etcdctl * add space * add note for etcdctl * remove note on etcd tag
fix #36533
Problem:
Set up a High Availability etcd Cluster with kubeadm mentions that you can check cluster health by running a docker run etcdctl command.
Kubernetes doesn't support Docker Engine natively any more.
Solution:
For checking etcd cluster health we can just use etcdctl command directly instead of docker run