Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace docker run for running etcdctl command with just etcdctl #39149

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

reetasingh
Copy link
Contributor

@reetasingh reetasingh commented Jan 29, 2023

fix #36533
Problem:
Set up a High Availability etcd Cluster with kubeadm mentions that you can check cluster health by running a docker run etcdctl command.

Kubernetes doesn't support Docker Engine natively any more.

Solution:
For checking etcd cluster health we can just use etcdctl command directly instead of docker run

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from onlydole January 29, 2023 22:32
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim January 29, 2023 22:32
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2023
@netlify
Copy link

netlify bot commented Jan 29, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 889f536
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63d6f418e87e8e000aec3722
😎 Deploy Preview https://deploy-preview-39149--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 29, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c8243c8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63d9de0d4be4b20009d6c7e2
😎 Deploy Preview https://deploy-preview-39149--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jan 29, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a3fc39a04099d39c9c74acd10c43e9bba52b6f1

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm January 31, 2023 06:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@tengqm
Copy link
Contributor

tengqm commented Jan 31, 2023

/lgtm
again

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b91cdf8873dfaa3790cdfed60b064445c0a03c79

1 similar comment
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b91cdf8873dfaa3790cdfed60b064445c0a03c79

Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@reetasingh reetasingh requested review from sftim and removed request for onlydole and tengqm February 1, 2023 03:51
@reetasingh
Copy link
Contributor Author

Hi @sftim can you please review this PR?

@tengqm
Copy link
Contributor

tengqm commented Feb 8, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbe99f06fe210fb283962d6d5adf6d7cfa5f16f4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit f3cfa2c into kubernetes:main Feb 8, 2023
DonatoHorn pushed a commit to DonatoHorn/website that referenced this pull request Jun 25, 2023
…ernetes#39149)

* replace docker run for running etcdctl command with just etcdctl

* add space

* add note for etcdctl

* remove note on etcd tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a High Availability etcd Cluster with kubeadm mentions testing with Docker
5 participants