Warn against managing ReplicaSets owned by Deployments #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michail Kargakis <[email protected]>
k8s-ci-robot
added
sig/apps
cncf-cla: yes
chenopis
reviewed
May 26, 2017
| create new resources, or replace existing ones by new ones. | ||
| create new ReplicaSets, or remove existing Deployments and adopt all of their resources with new Deployments. | ||
|
|
||
| **Note** You should not manage ReplicaSets owned by a Deployment, otherwise you are racing with the Deployment |
There was a problem hiding this comment.
Minor nit, put a colon after note, i.e. Note:
Looks good otherwise.
|
LGTM |
|
I'll just merge this and make a change in a follow-up PR. |
Merged
chenopis
added a commit
that referenced
this pull request
May 31, 2017
…hub.io into release-1.7 * 'master' of https://github.com/kubernetes/kubernetes.github.io: Fix log rotation description in the logging doc (#3918) Add colon to #3897 add prompt about KUBE_REPO_PREFIX (#3597) Warn against managing ReplicaSets owned by Deployments Update small typo in components page (#3930) change the service name to pod ip (#3926)
chenopis
added a commit
that referenced
this pull request
May 31, 2017
…hub.io into release-1.6 * 'master' of https://github.com/kubernetes/kubernetes.github.io: networking.md: Add reference to the Cilium network plugin Fix typo in cluster api docs [Kubeadm] bugfix in the index listing Fix log rotation description in the logging doc (#3918) Add colon to #3897 add prompt about KUBE_REPO_PREFIX (#3597) Warn against managing ReplicaSets owned by Deployments Update small typo in components page (#3930) change the service name to pod ip (#3926)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kubernetes/sig-apps-misc
This change is