Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-daemonsets to docs of kubectl drain #38917

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Jan 13, 2023

In most cases kubectl drain gets used with --ignore-daemonsets. The docs should reflect that.

The explanation text of the PR is from the reference:

https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 13, 2023
@netlify
Copy link

netlify bot commented Jan 13, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c192062
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63c5543e0ccba000094fafa7
😎 Deploy Preview https://deploy-preview-38917--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a single suggestion

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guettli !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@guettli
Copy link
Contributor Author

guettli commented Jan 20, 2023

@divya-mohan0209 thank you for the "approve". What are the next steps now? I see:

tide: Pending — Not mergeable. Needs lgtm label.

@sftim
Copy link
Contributor

sftim commented Jan 20, 2023

What are the next steps now?

We haven't documented this, but the next step is for a different contributor to check that the changes are technically correct and follow the docs style guide (at least, enough to justify a merge).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ee3d7f93a222fe75f7179563dcdd132275fe211

@k8s-ci-robot k8s-ci-robot merged commit e2e50d0 into kubernetes:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants