-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore-daemonsets
to docs of kubectl drain
#38917
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Tim Bannister <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a single suggestion
Co-authored-by: divya-mohan0209 <[email protected]>
thank you Co-authored-by: divya-mohan0209 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @guettli !
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@divya-mohan0209 thank you for the "approve". What are the next steps now? I see:
|
We haven't documented this, but the next step is for a different contributor to check that the changes are technically correct and follow the docs style guide (at least, enough to justify a merge). /lgtm |
LGTM label has been added. Git tree hash: 5ee3d7f93a222fe75f7179563dcdd132275fe211
|
In most cases
kubectl drain
gets used with--ignore-daemonsets
. The docs should reflect that.The explanation text of the PR is from the reference:
https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain