Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS_ALIASES cleanup part 2 #38853

Merged
merged 5 commits into from
Jan 18, 2023
Merged

OWNERS_ALIASES cleanup part 2 #38853

merged 5 commits into from
Jan 18, 2023

Conversation

divya-mohan0209
Copy link
Contributor

Context

This is the second PR in the series, starting with #38719. We've used the maintainers tool to parse the OWNERS file for inactive/low-activity GitHub handles based on their devstats contributions for 2022. This was done in late November & you can view the complete output on the #sig-docs-maintainers slack channel. Some part of the pruning was already completed via PRs by @saschagrunert and me in early December/late November.

What this PR does?

The following approvers and reviewers in the OWNERS_ALIASES file have had low reviews/approvals in the past year (GH pr comments <= 10 && devstats <=20). This PR prunes them from the OWNERS_ALIASES file, failing any response from their side.

What do I need to do?

Please comment on this PR if you have been tagged on the list below and still have time/interest to contribute. If you'd prefer to let us know your decision via DM, please initiate a group chat with @natalisucks, @reylejano, and me on Slack by 17th January 2023 EOD.

Further steps

I'll also email the SIG Docs google group and post threads on the #sig-docs and #sig-docs-maintainers slack channels for further visibility.

@claudiajkang
@MaxymVlasov
@ariscahyadi
@AWKIF
@danninov
@girikuncoro
@huynguyennovem
@jailton
@jhonmike
@kpucynski
@makocchi-git
@nvtkaszpir
@perriea
@rekcah78
@truongnh1992
@yagonobre

/assign @a-mccarthy @kbhawkey @natalisucks @onlydole @sftim @tengqm @reylejano

Explicit hold for discussions till 17th January 2023.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2023
@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 44d0144
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63c60e84f0b33f0008d75f44
😎 Deploy Preview https://deploy-preview-38853--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MaxymVlasov
Copy link
Member

MaxymVlasov commented Jan 10, 2023 •
edited
Loading

Hi there. I'm actively reviewing all stuff related uk docs. If there are not many contributions - that's not my fault. I would glad to see new contributors and their contributions to be able to review them, but for now that all what we have.

@Sea-n
Copy link
Member

Sea-n commented Jan 10, 2023 •
edited
Loading

After this PR merged (as is), we will have no approver for vi.
For id (@habibrosyad) and pl (@mfilocha), there will be only one approver.

Not sure will it be a problem or not. (Since the sig-docs-leads can still approve those PRs.)

@divya-mohan0209
Copy link
Contributor Author

Hello @MaxymVlasov. As mentioned above, the number above is based on GitHub PRs and Devstats. We understand localizations might have a low flow of incoming PRs for reviews & approvals, which is why this PR was created to confirm your interest in continuing to contribute. Thank you for confirming your interest!

@divya-mohan0209
Copy link
Contributor Author

@Sea-n As mentioned above, this is a PR to confirm your interest in continuing to contribute this year. As @MaxymVlasov pointed out, GitHub comments and devstats might not be an accurate indicator if the number of incoming requests is low. The PR was opened to frame a discussion. Only failing a response or an explicit resignation will the individual be removed.

Additionally, for localizations with single or no maintainers, the idea is to frame a separate discussion post the merge of this PR to understand our options.

@rekcah78
Copy link
Contributor

Hello,
I still review/approve PR for fr language

@AWKIF
Copy link
Contributor

AWKIF commented Jan 10, 2023

Hi,
can you keep me there as i'm also reviewing PR,
thanks :)

@huynguyennovem
Copy link
Member

Hi @divya-mohan0209, I still can review/approve PR for vi language.

@yagonobre
Copy link
Member

yagonobre commented Jan 10, 2023 via email

@truongnh1992
Copy link
Member

Hi @divya-mohan0209
I'll still review/approve PR for vi language.

@nvtkaszpir
Copy link
Member

Hi,
I still review/approve PR for pl language.

sftim
sftim reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where we take localizations down to 1 owner, we should file an issue and consider what action is appropriate to deal with the low number of active maintainers.

OWNERS_ALIASES Outdated
Comment on lines 84 to 88
sig-docs-id-owners: # Admins for Indonesian content
- ariscahyadi
- danninov
- girikuncoro
# ariscahyadi
# danninov
# girikuncoro
- habibrosyad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leave Indonesian unviable as a localization (only 1 owner)

OWNERS_ALIASES Outdated
Comment on lines 182 to 184
sig-docs-vi-owners: # Admins for Vietnamese content
- huynguyennovem
- truongnh1992
# huynguyennovem
# truongnh1992
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leave Vietnamese unviable as a localization (only 1 owner)

OWNERS_ALIASES Outdated
Comment on lines 194 to 196
sig-docs-pl-owners: # Admins for Polish content
- mfilocha
- nvtkaszpir
# nvtkaszpir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leave Polish unviable as a localization (only 1 owner)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim - @nvtkaszpir confirmed his readiness to help, see PR's comments above.

@kpucynski
Copy link
Member

Hi,
I still review PRs for PL language.
Don't delete me ;)

@perriea
Copy link
Member

perriea commented Jan 12, 2023 •
edited
Loading

Hello,
I still review/approve PR for fr language :)

@danninov
Copy link
Contributor

Hi,
You can keep me for id language. Thanks

@girikuncoro
Copy link
Contributor

girikuncoro commented Jan 13, 2023 via email

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2023
@divya-mohan0209
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@MaxymVlasov MaxymVlasov mentioned this pull request Jan 16, 2023
Closed
@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 956c7ee169f5e2d02cee07728c862f5b22f920b9

@divya-mohan0209
Copy link
Contributor Author

I'm sorry for the confusion, but we'll need to hold this PR till I verify some discrepancies brought to my notice by @MaxymVlasov (thanks!). Once done, I shall unhold it again.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2023
@divya-mohan0209
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71c64340387e149bfcf7974b7e1a9911a48cd998

@reylejano
Copy link
Member

The explicit hold for discussions ended on January 17, 2023 as stated in this PR's description
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit d9f63c7 into kubernetes:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfilocha mfilocha mfilocha left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@reylejano reylejano Awaiting requested review from reylejano

@a-mccarthy a-mccarthy Awaiting requested review from a-mccarthy

@natalisucks natalisucks Awaiting requested review from natalisucks

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@onlydole onlydole

@kbhawkey kbhawkey

@tengqm tengqm

@natalisucks natalisucks

@a-mccarthy a-mccarthy

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.