Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in the Deployment doc #3862

Merged
merged 1 commit into from
May 24, 2017
Merged

Minor fixes in the Deployment doc #3862

merged 1 commit into from
May 24, 2017

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented May 20, 2017

Both of the essential changes in this PR should be effective in 1.7

Ready replicas are accounted as progress: kubernetes/kubernetes#46169
Deployments are complete once all of their underlying pods are available: kubernetes/kubernetes#44672


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2017
@0xmichalis 0xmichalis added this to the 1.7 milestone May 22, 2017
@chenopis chenopis changed the base branch from master to release-1.7 May 22, 2017 19:40
Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once small nit.

* The Deployment creates a new ReplicaSet.
* The Deployment is scaling up its newest ReplicaSet.
* The Deployment is scaling down its older ReplicaSet(s).
* New Pods become ready or available (ready for at least [MinReadySeconds](#min-ready-seconds).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need another ')' at the end of the sentence to close the parenthetical.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Michail Kargakis <[email protected]>
@chenopis chenopis merged commit d0bfe26 into kubernetes:release-1.7 May 24, 2017
@0xmichalis 0xmichalis deleted the minor-deployment-fixes branch May 24, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants