Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Update content/ja/docs/concepts/overview/components.md file #38547

Merged
merged 10 commits into from
Jan 3, 2023
Merged

[ja] Update content/ja/docs/concepts/overview/components.md file #38547

merged 10 commits into from
Jan 3, 2023

Conversation

ziyi-xie
Copy link
Contributor

There are several updates in the original English text and therefore this page is outdated.
This PR updated Japanese translation for the /content/ja/docs/concepts/overview/components.md file.

Fixes #38544

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kakts December 19, 2022 07:14
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2022
@ziyi-xie
Copy link
Contributor Author

/assign @nasa9084
/cc @atoato88 @t-inu
Hi! I've updated Japanese translation for the /content/ja/docs/concepts/overview/components.md file, would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

@k8s-ci-robot k8s-ci-robot requested a review from t-inu December 19, 2022 07:16
@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1c7e733
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63a27767a6c4df0008a48fbe
😎 Deploy Preview https://deploy-preview-38547--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atoato88
Copy link
Contributor

The title of this PR says "Update /content/ja/docs/concepts/services-networking/ingress.md", but the file updated is "content/ja/docs/concepts/overview/components.md".
Is this right title?

@ziyi-xie
Copy link
Contributor Author

/retitle [ja] Update content/ja/docs/concepts/overview/components.md file

@k8s-ci-robot k8s-ci-robot changed the title [ja] Update /content/ja/docs/concepts/services-networking/ingress.md file [ja] Update content/ja/docs/concepts/overview/components.md file Dec 20, 2022
@ziyi-xie
Copy link
Contributor Author

@atoato88 I just modified the title and thank you so much for your comment!

atoato88
atoato88 reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
ziyi-xie and others added 8 commits December 20, 2022 17:16
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
4ad0533 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
6f72c40 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
7f9d747 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
3ecc11a 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
e434768 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
061fa70 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
ab38df2 
Co-authored-by: atoato88 <[email protected]>
@ziyi-xie @atoato88
Update content/ja/docs/concepts/overview/components.md
75b78f8 
Co-authored-by: atoato88 <[email protected]>
@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2022
@atoato88
Copy link
Contributor

atoato88 commented Jan 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1aabd17bb99717d0933ac96440307e87838981c8

@k8s-ci-robot k8s-ci-robot merged commit 5e03336 into kubernetes:main Jan 3, 2023
@ziyi-xie ziyi-xie deleted the update-components branch January 3, 2023 23:41
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@kakts kakts Awaiting requested review from kakts

@t-inu t-inu Awaiting requested review from t-inu

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] /content/ja/docs/concepts/overview/components.md is outdated
5 participants
@ziyi-xie @atoato88 @nasa9084 @k8s-ci-robot @t-inu