Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature blog for CEL for Admission Control #38162

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add feature blog for CEL for Admission Control #38162

merged 2 commits into from
Dec 13, 2022

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Nov 29, 2022

PR for feature blog on KEP: kubernetes/enhancements#3488

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2022
@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 37b6582
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/63866837bfebfd0008800fe7

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 29, 2022
@jpbetz jpbetz mentioned this pull request Nov 29, 2022
Closed
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 29, 2022

cc @fsm @sftim

@sftim
Copy link
Contributor

sftim commented Nov 29, 2022

Thanks

/hold

OK to unhold once this targets main and has a publication date assigned.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022
@jpbetz jpbetz force-pushed the validating-admission-policies-blog-1_26 branch from 91f7988 to 37b6582 Compare November 29, 2022 20:14
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2022
@jpbetz jpbetz changed the base branch from dev-1.26 to main November 29, 2022 20:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 29, 2022

Retargeted against main.

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2022
@sftim
Copy link
Contributor

sftim commented Nov 29, 2022

/remove-language fr
/remove-language hi
/remove-language ja
/remove-language pt
/remove-language zh
/remove-sig release

cici37
cici37 reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@cici37 cici37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM from technical side, just couple nits

content/en/blog/_posts/2022-12-20-validating-admission-policies-alpha/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-20-validating-admission-policies-alpha/index.md Outdated Show resolved Hide resolved
@jpbetz jpbetz force-pushed the validating-admission-policies-blog-1_26 branch from 99aa68b to 11ed16b Compare December 7, 2022 17:19
@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

/hold
OK to unhold once v1.26 is released.

@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

/lgtm
/approve

Remember, we can accept tweaks between merging this PR and publication of the article (or even afterwards; for something like a typo fix, approval is pretty trivial).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 7, 2022

Thanks for your help @sftim, @cici37, @JimBugwadia !

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim December 7, 2022 18:02
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 7, 2022

Made a few small edits to address @JimBugwadia's comments. Leaving the hold in place until 1.26 is released.

@jpbetz jpbetz force-pushed the validating-admission-policies-blog-1_26 branch from 91f1874 to 44f241b Compare December 7, 2022 18:05
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 7, 2022

squashed

@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

/remove-label tide/merge-method-squash

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Dec 7, 2022
@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

Hmm, good point!

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@sftim
Copy link
Contributor

sftim commented Dec 11, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2022
@sftim @jmcshane
Fix typo in sample manifest
1d10bd5 
Co-authored-by: James McShane <[email protected]>
@sftim
Copy link
Contributor

sftim commented Dec 13, 2022

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57e2439ab77717ab54d3f3cd6292a6a27a0ade8c

@k8s-ci-robot k8s-ci-robot merged commit 037def8 into kubernetes:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcshane jmcshane jmcshane left review comments

@cici37 cici37 cici37 left review comments

@JimBugwadia JimBugwadia JimBugwadia left review comments

@fsmunoz fsmunoz fsmunoz left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
8 participants
@jpbetz @sftim @fsmunoz @tengqm @k8s-ci-robot @JimBugwadia @cici37 @jmcshane