Clarify node affinity API #38032
Merged
Clarify node affinity API #38032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
cortespao
reviewed
Nov 23, 2022
Comment on lines
151
to
152
| If you specify multiple expressions in `matchExpressions` associated with a single term in `nodeSelectorTerms`, | ||
| then the Pod can be scheduled onto a node only if all the expressions are satisfied. |
There was a problem hiding this comment.
Suggested change
| If you specify multiple expressions in `matchExpressions` associated with a single term in `nodeSelectorTerms`, | |
| then the Pod can be scheduled onto a node only if all the expressions are satisfied. | |
| If you specify multiple expressions in a single `matchExpressions` associated in a `nodeSelectorTerms`, | |
| then the Pod can be scheduled onto a node only if _all_ the expressions are satisfied (expressions are ANDed). |
There was a problem hiding this comment.
added the word "field"
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8324ba0fe06ef6f794f83a3930bb9694b6c557e8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31769
I don't think there was anything wrong with the existing wording, but it was confusing. It was not clear whether it was referring to the mentions of the field or the items within the field.
Also replace @bsalamat with @alculquicondor, as a SIG Scheduling TL