KEP-2133: update doc references for KubeletCredentialProviders #37920
Conversation
Signed-off-by: Andrew Sy Kim <[email protected]>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
|
/assign @ndixita @ruiwen-zhao |
|
@andrewsykim: GitHub didn't allow me to assign the following users: ndixita. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Almost LGTM, but I strongly recommend that we also update https://kubernetes.io/docs/concepts/containers/images/#configuring-nodes-to-authenticate-to-a-private-registry to link to the kubelet credential provider setup task page.
| @@ -7,7 +7,7 @@ description: Configure the kubelet's image credential provider plugin | |||
| content_type: task | |||
| --- | |||
|
|
|||
| {{< feature-state for_k8s_version="v1.24" state="beta" >}} | |||
| {{< feature-state for_k8s_version="v1.26" state="stable" >}} | |||
|
|
|||
| <!-- overview --> | |||
There was a problem hiding this comment.
This is good to go. With caveats.
Ideally, open a follow up PR and in that PR:
-
write the first occurrence of exec plugins in italics
-
consider rewording that italicized text to credential helper plugins
-
tweak the text
a single subdomain segment, so
*.iodoes NOT match*.k8s.io.and change it to use bold, not caps, for emphasis, like this
a single subdomain segment, so `*.io` does **not** match `*.k8s.io`.
Is this still the latest (alpha) version:
apiVersion: kubelet.config.k8s.io/v1alpha1
kind: CredentialProviderConfig
?
If not, we need a few updates.
| @@ -281,6 +279,9 @@ For a reference to old feature gates that are removed, please refer to | |||
| | `IndexedJob` | `false` | Alpha | 1.21 | 1.21 | | |||
| | `IndexedJob` | `true` | Beta | 1.22 | 1.23 | | |||
| | `IndexedJob` | `true` | GA | 1.24 | - | | |||
| | `KubeletCredentialProviders` | `false` | Alpha | 1.20 | 1.23 | | |||
| | `KubeletCredentialProviders` | `true` | Beta | 1.24 | 1.26 | | |||
There was a problem hiding this comment.
nit / needs fixing really
| | `KubeletCredentialProviders` | `true` | Beta | 1.24 | 1.26 | | |
| | `KubeletCredentialProviders` | `true` | Beta | 1.24 | 1.25 | |
k8s-ci-robot
added
the
needs-rebase
|
@andrewsykim: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing in favor of #38006 /close |
|
@andrewsykim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Andrew Sy Kim [email protected]
kubernetes/enhancements#2133