Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1672: update docs for EndpointSliceTerminatingCondition #37913

Closed
wants to merge 2 commits into from
Closed

KEP-1672: update docs for EndpointSliceTerminatingCondition #37913

wants to merge 2 commits into from

Conversation

andrewsykim
Copy link
Member

Update docs for EndpointSliceTerminatingCondition

kubernetes/enhancements#1672

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c36dd9b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6388c4a82e1151000943edd4

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 15, 2022
@andrewsykim andrewsykim mentioned this pull request Nov 15, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2022
sftim
sftim reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. These changes should fix the build.

content/en/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -606,7 +607,7 @@ Each feature gate is designed for enabling/disabling a specific feature:
filesystem walk for better performance and accuracy.
- `LogarithmicScaleDown`: Enable semi-random selection of pods to evict on controller scaledown
based on logarithmic bucketing of pod timestamps.
- `MatchLabelKeysInPodTopologySpread`: Enable the `matchLabelKeys` field for
- `MatchLabelKeysInPodTopologySpread`: Enable the `matchLabelKeys` field for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, don't let your editor touch this line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my editor is configured to automatically format any file on save 🙃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2022
@leonardpahlke
Copy link
Member

cc @krol3, we need to track this too. Atm checking with Enhancements why we removed it from the milestone kubernetes/enhancements#1672 (comment)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
@leonardpahlke
Copy link
Member

Awesome, lets get this in ASAP for 1.26

sftim
sftim reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these condition names written camel case (camelCaseExample aka lowerCamelCaseExample), Pascal case (PascalCaseExample), initial caps (Initialcapsexample) or something else?

For GA, we should get details like this right.

@andrewsykim
Copy link
Member Author

Are these condition names written camel case (camelCaseExample aka lowerCamelCaseExample), Pascal case (PascalCaseExample), initial caps (Initialcapsexample) or something else?

Updated conditions to use lower case

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2022
@sftim
Copy link
Contributor

sftim commented Dec 1, 2022

This looks ready for tech review.

@andrewsykim
Copy link
Member Author

/assign @robscott

@robscott
Copy link
Member

robscott commented Dec 1, 2022

Thanks @andrewsykim!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@sftim
Copy link
Contributor

sftim commented Dec 10, 2022

Hi. This now needs to target main

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2022
@tengqm tengqm deleted the branch kubernetes:dev-1.26 December 10, 2022 03:41
@tengqm tengqm closed this Dec 10, 2022
@sftim sftim mentioned this pull request Dec 10, 2022
Closed
@YashPimple YashPimple mentioned this pull request Dec 10, 2022
Closed
@reylejano reylejano mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@freehan freehan Awaiting requested review from freehan

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@sftim sftim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewsykim @k8s-ci-robot @leonardpahlke @sftim @robscott @tengqm