Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more points in what's next section of Understanding Kubernetes … #37747

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Added more points in what's next section of Understanding Kubernetes … #37747

merged 3 commits into from
Nov 12, 2022

Conversation

T-Lakshmi
Copy link
Contributor

This PR adding 2 more points under what's next section of Understanding Kubernetes objects page.

Fixes #37714

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2022
@T-Lakshmi T-Lakshmi mentioned this pull request Nov 7, 2022
Closed
@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3607e97
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/636b44b8981f2800087ca9e0
😎 Deploy Preview https://deploy-preview-37747--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

divya-mohan0209
divya-mohan0209 reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these are fine, the phrasing Learn more about XYZ seems super repetitive especially with the new additions. Is it possible to rephrase them?

@T-Lakshmi
Copy link
Contributor Author

T-Lakshmi commented Nov 7, 2022 •
edited
Loading

Hi @divya-mohan0209,
How about this.

Learn more about the Following.

  • Most important basic Kubernetes objects, such as Pod.
  • Controllers in Kubernetes.
  • Kubernetes API which explains some more API concepts.
  • Deployments.
  • kubectl and kubectl commands.

If this seems good then I will update it. WDYT?

@divya-mohan0209
Copy link
Contributor

I like the idea. However, you'll need to rework the casing & the grammar for the suggestion.

@T-Lakshmi
Copy link
Contributor Author

Sure, I will take care of it.

@T-Lakshmi
Copy link
Contributor Author

Hi @divya-mohan0209 ,
I have updated the changes we discussed above.
Could you please take a look.

reylejano
reylejano reviewed Nov 8, 2022
View reviewed changes
content/en/docs/concepts/overview/working-with-objects/kubernetes-objects.md Outdated
* Learn about the most important basic Kubernetes objects, such as [Pod](/docs/concepts/workloads/pods/).
* Learn about [controllers](/docs/concepts/architecture/controller/) in Kubernetes.
* [Using the Kubernetes API](/docs/reference/using-api/) explains some more API concepts.
Learn more about the following.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
Learn more about the following.
Learn more about the following:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reylejano,
Thanks for your valuable suggestion.

i have incorporated the above suggestion.

@reylejano
Copy link
Member

reylejano commented Nov 9, 2022 •
edited
Loading

Preview of updated page:
https://deploy-preview-37747--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/working-with-objects/kubernetes-objects/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b77b5e46cd4375bec4d590b2606b5a6f40497d31

@T-Lakshmi
Copy link
Contributor Author

/assign @nate-double-u
Could you please approve PR.

nate-double-u
nate-double-u reviewed Nov 12, 2022
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @T-Lakshmi

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1cff40e into kubernetes:main Nov 12, 2022
@windsonsea windsonsea mentioned this pull request Nov 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@nate-double-u nate-double-u nate-double-u left review comments

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@nate-double-u nate-double-u

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more items in what's next section of Understanding Kubernetes objects
5 participants
@T-Lakshmi @divya-mohan0209 @reylejano @k8s-ci-robot @nate-double-u