Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog post about Kluctl and its use of SSA #37563

Merged
merged 15 commits into from
Nov 1, 2022

Conversation

codablock
Copy link
Contributor

This PR proposes a blog post about the use of SSA in Kluctl. Creating this post was suggested to me when I contacted #sig-api-machinery after reading the recent "Server Side Apply Is Great And You Should Be Using It" blog post.

I hope this post is of some value for the Kubernetes blog. I'm not sure how reviews are usually performed here and hope that it's ok that I used this early draft to directly create the PR. If preferred, I can also copy this into a Google Doc and let review happen there first.

The post also contains a link to the podtato-head repository. This link is currently dead as it refers to a directory that did not get merged yet. The PR for this can be found here. Until then, you can check this link for now to see what will be shown behind that link in the future.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 27, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @codablock!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2022
@netlify
Copy link

netlify bot commented Oct 27, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c8dd619
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/635eb60cf74ca80009df7c0b
😎 Deploy Preview https://deploy-preview-37563--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback; I hope that it's useful. None of these are must-fix-right-now things.

Copy link
Contributor

@mocdaniel mocdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestions in places where I spotted typos or stumbled over very (to me) German-in-style formulated passages (I know the pain...).

Apart from that, from the perspective of someone who's still discovering new features and tools in and around Kubernetes everyday, this is a very good blog post imo. Concise, diving into the history of things in the right places, with a convincing motivation.

@codablock
Copy link
Contributor Author

Pushed a new version with all the review comments being handled.

@sftim
Copy link
Contributor

sftim commented Oct 28, 2022

@codablock please set the publish date for the article to be the 4th of November (you need to change it in 2 places, the front matter and the filename)

/hold
pending that update

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022
@codablock
Copy link
Contributor Author

codablock commented Oct 28, 2022

Handled remaining review comments and changed the publish date to 2022-11-04. I've also temporarily changed the links to the podtato-head delivery scenario to be pointing to my fork until it gets merged (can't say how long this will take).

@sftim
Copy link
Contributor

sftim commented Oct 29, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2022
@sftim
Copy link
Contributor

sftim commented Oct 30, 2022

/lgtm

Would be nice to make the byline match how we usually do them.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25ad82b9f2e5b79e6375ca93c56e83c97c2b54dd

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim October 30, 2022 17:36
The way SSA is implemented in `kubectl` does not allow enough
control over conflict resolution as it can only switch between
"not force-applying anything and erroring out" and "force-applying everything
without showing any mercy!".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apelisse and I have talked about adding a mechanism to tell the server which fields you want to force apply, thanks for the evidence that we would have at least one user ;)

@lavalamp
Copy link
Member

I think this is a great case study, thank you very much for submitting it!

@sftim
Copy link
Contributor

sftim commented Nov 1, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@sftim
Copy link
Contributor

sftim commented Nov 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3de447e73f3b45d2891b728971c576f1250c8ee

@k8s-ci-robot k8s-ci-robot merged commit df20e98 into kubernetes:main Nov 1, 2022
@codablock codablock deleted the blog-kluctl-ssa branch November 2, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants