Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page weights to concepts -> storage pages #37518

Conversation

chrisnegus
Copy link
Contributor

@chrisnegus chrisnegus commented Oct 25, 2022

Updates page weights for concepts/storage pages. Matching the current English language sorting:

volumes.md:weight: 10
persistent-volumes.md:weight: 20
projected-volumes.md:weight: 21 # just after persistent volumes
ephemeral-volumes.md:weight: 30
storage-classes.md:weight: 35
dynamic-provisioning.md:weight: 40
volume-snapshots.md:weight: 45
volume-snapshot-classes.md:weight: 46 # just after volume snapshots
volume-pvc-datasource.md:weight: 60
storage-capacity.md:weight: 70
storage-limits.md 80
volume-health-monitoring.md 90
windows-storage.md  100

See Issue 325093.
@natalisucks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval by writing /assign @divya-mohan0209 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisnegus
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 25, 2022
@netlify
Copy link

netlify bot commented Oct 25, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e3d8d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63581eb55da2ff00089823b7
😎 Deploy Preview https://deploy-preview-37518--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

@chrisnegus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2022
@jihoon-seo
Copy link
Member

@chrisnegus GitHub says that there is a merge conflict. It would be great if a rebase is performed.

@Kartik494
Copy link
Contributor

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 1, 2022
@sftim
Copy link
Contributor

sftim commented Nov 1, 2022

Did this already get done in a different PR?

@nate-double-u
Copy link
Contributor

Did this already get done in a different PR?

It looks like it.
I'm going to close this as complete. Thanks for participating in the docs sprint @chrisnegus!

@chrisnegus
Copy link
Contributor Author

Sorry I didn't see this sooner. Someone else did the changes intended by this PR. Closing it was right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants