Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeCon Docs Sprint: Update page weights for content/en/docs/concepts/scheduling-eviction #37493

Closed

Conversation

haosdent
Copy link
Member

contributes to #35093

Updates page weights in content/en/docs/concepts/scheduling-eviction

Before my changes:
image
After my changes:
image

cc @nate-double-u

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jimangel for approval by writing /assign @jimangel in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2022
@netlify
Copy link

netlify bot commented Oct 24, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ad65791
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6356e78069099f0009a1a8f2
😎 Deploy Preview https://deploy-preview-37493--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Oct 24, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

@haosdent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022
@jihoon-seo
Copy link
Member

jihoon-seo commented Nov 1, 2022

@haosdent GitHub says that there is a merge conflict. It would be great if a rebase is performed.
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 1, 2022
@sftim
Copy link
Contributor

sftim commented Nov 1, 2022

/remove-label tide/merge-method-squash

This will need a merge or rebase I'm afraid. A rebase against main is better. @haosdent if you'd like, one of the website maintainers can do that rebase and update this PR with those changes.

Should we do that?

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 1, 2022
@haosdent
Copy link
Member Author

haosdent commented Nov 2, 2022

@sftim sure!

@nate-double-u
Copy link
Contributor

Hi @haosdent, could you resolve the merge conflicts on this before we merge it in?

@nate-double-u
Copy link
Contributor

Actually, looking closer, it seems like this work was done in a prior PR.

I'm going to close this as complete. Thanks for participating in the docs sprint @haosdent!

@haosdent
Copy link
Member Author

haosdent commented Nov 3, 2022

Noted, thanks @nate-double-u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants