Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeCon Docs Sprint: Update Weights for Setup and Subfolders #37482

Merged
merged 2 commits into from
Nov 1, 2022
Merged

KubeCon Docs Sprint: Update Weights for Setup and Subfolders #37482

merged 2 commits into from
Nov 1, 2022

Conversation

cailyn-codes
Copy link
Contributor

This PR updates duplicated weights in the setup folder and it sub folders.

Related # #35093

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 24, 2022
@nate-double-u
Copy link
Contributor

Thanks @cailynse!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2cc5bfb93f45e7abc71747be43e5d7d1866b38a8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@nate-double-u
Copy link
Contributor

@reylejano @natalisucks deploy preview fail... could you take a look?

@sftim
Copy link
Contributor

sftim commented Oct 24, 2022

/kind cleanup
/approve

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Oct 24, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e76239c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63584b0c476d660009909631
😎 Deploy Preview https://deploy-preview-37482--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Rishit-dagli
Rishit-dagli reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@Rishit-dagli Rishit-dagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a simple rerun of the tests should do it.
/retest

@cailyn-codes
Copy link
Contributor Author

/retest

@sftim
Copy link
Contributor

sftim commented Oct 25, 2022

I'm afraid that Prow doesn't know how to trigger another build attempt by Netlify. Not yet.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@cailyn-codes
Copy link
Contributor Author

I reduced a weight that was 30 above to be only 20 above in order to trigger the netlify build again

@cailyn-codes cailyn-codes requested review from Rishit-dagli and removed request for lavalamp and nate-double-u October 26, 2022 15:34
@sftim
Copy link
Contributor

sftim commented Nov 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3200d0212238d0bd2fe3214ec8adb652f740fc7

@k8s-ci-robot k8s-ci-robot merged commit 0af0de0 into kubernetes:main Nov 1, 2022
@niuzhenguo niuzhenguo mentioned this pull request Nov 9, 2022
Merged
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rishit-dagli Rishit-dagli Awaiting requested review from Rishit-dagli

Assignees

@nate-double-u nate-double-u

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cailyn-codes @nate-double-u @k8s-ci-robot @sftim @Rishit-dagli