Change weight for localization correctness #37479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
needs-rebase
|
Hi @spzala this needs a rebase |
spzala
force-pushed
the
docsprintspzala2
branch
from
4b78890 to
a3cb11f
Compare
k8s-ci-robot
added
size/XS
bradtopol
reviewed
Oct 24, 2022
| @@ -3,7 +3,7 @@ reviewers: | |||
| - mikedanese | |||
| title: Labels and Selectors | |||
| content_type: concept | |||
| weight: 40 | |||
| weight: 70 | |||
There was a problem hiding this comment.
Labels appeared to move from the last entry to higher up. I think you need to try adjusting the weights
Keeping index files weight as such. Also, no changes to the card index as they are not needed. Part of the work at Doc Sprint KubeCon NA 2022. Related # kubernetes#35093 Signed-off-by: Sahdev Zala <[email protected]>
spzala
force-pushed
the
docsprintspzala2
branch
from
a3cb11f to
95683e0
Compare
|
Great job! Looks much better! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d70855e83ca77356883c3f0d4901cd0b3390d82c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradtopol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping index files weight as such. Also, no changes to the card index as they are not needed. Other files weights are changed in increment of 10.
Part of the work at Doc Sprint KubeCon NA 2022.
Related # #35093
Signed-off-by: Sahdev Zala [email protected]