Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EndpointSlice concept #37386

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Improve EndpointSlice concept #37386

merged 1 commit into from
Nov 20, 2022

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Oct 19, 2022

Split out from #30817

  • add links to API references
  • tweak initial text

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
@sftim sftim mentioned this pull request Oct 19, 2022
Closed
@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 024e8d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6378f10640e45100086e4cac
😎 Deploy Preview https://deploy-preview-37386--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor Author

sftim commented Nov 1, 2022

Should help with #14770

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2022
@sftim sftim force-pushed the 20221019_improve_endpointslice_page branch from df7609e to 72c6a03 Compare November 11, 2022 12:48
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2022
@sftim
Improve EndpointSlice concept
024e8d7 
- add links to API references
- tweak initial text
@sftim sftim force-pushed the 20221019_improve_endpointslice_page branch from 72c6a03 to 024e8d7 Compare November 19, 2022 15:06
@tengqm
Copy link
Contributor

tengqm commented Nov 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 504cb28417d8252fa136d79d8d30f29330efb2c6

@k8s-ci-robot k8s-ci-robot merged commit efa29bf into kubernetes:main Nov 20, 2022
@windsonsea windsonsea mentioned this pull request Nov 20, 2022
Merged
@sftim sftim deleted the 20221019_improve_endpointslice_page branch September 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@freehan freehan Awaiting requested review from freehan

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @reylejano @k8s-ci-robot @tengqm