-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Installing kubeadm topic. #3709
Conversation
@bgrant0607, Can you comment on whether you think this PR is heading in the right direction? The last time you and I met, we discussed the idea of having a set of Tasks for installing tools like kubectl, minikube, kubeadm, helm, etc. I like the idea putting tool installation in its own section. But on the other hand, I'm concerned about factoring tool installation out of Setup topics like Installing Kubernetes on Linux with kubeadm. I really don't want to duplicate the installation instructions for a given tool, so I think we should choose one approach or the other. |
@steveperry-53 Creating a kubeadm installation task makes sense to me. I could imagine someone wanting to know just that. Is the concern that it would only be referenced by the guide that explains how to use kubeadm to create a cluster? I expect to have multiple kubeadm-related guides, for creating different types of clusters, updating clusters, etc. |
@bgrant0607 My concern is about where to put the How to Install kubeadm topic. In the top nav, we have a Setup, Concepts, Tasks, ... I'm thinking that How to Install kubeadm should not be under Tasks. Instead it should be under Setup, along with the other topics that talk about how to use kubeadm to create/update clusters. |
Installing anything (kubeadm, kubectl, etc.) is probably "Setup". However, we want to make docs easy to find. Is it not possible to list the topic under multiple categories? |
@bgrant0607 OK, we'll put the Installing topics under Setup. I'll look into listing topics in multiple places. I think we can do that. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…hub.io into release-1.7 * 'master' of https://github.com/kubernetes/kubernetes.github.io: Create Installing kubeadm topic. (#3709)
…hub.io into release-1.6 * 'master' of https://github.com/kubernetes/kubernetes.github.io: Improve RBAC doc (#3951) Clarify CNI acronym Fix 404 to kubectl install link install-kubectl.md: Fix Windows texts, link to latest macOS binaries Create Installing kubeadm topic. (#3709)
…hub.io * 'master' of https://github.com/kubernetes/kubernetes.github.io: (859 commits) fixed the line giving the template for creating configmap, should include the word configmap as part of the creation process. Fixes issue kubernetes#3939 Add CRI runtime support Updaated install-kubeadm.md, removed redundant kubectl installation (kubernetes#4006) Add Chocolatey Package Manager for Windows (kubernetes#4000) Make issue title automatically a link Update directions for macOS bash completion Add TCP socket health check example (kubernetes#3977) Update networking.md (kubernetes#3950) [authorization] fix invalid href for webhook Remove self-referential link Add fibre channel volume explanation (kubernetes#3967) Improve RBAC doc (kubernetes#3951) Clarify CNI acronym Fix 404 to kubectl install link install-kubectl.md: Fix Windows texts, link to latest macOS binaries Create Installing kubeadm topic. (kubernetes#3709) Fix example in the "Adding ConfigMap data to a Volume" section Update ExternalName example Completes PR kubernetes#3325 ... # Conflicts: # _data/tasks.yml # docs/tasks/administer-cluster/namespaces-walkthrough.md # docs/tasks/administer-cluster/namespaces.md
This change is