-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favor EndpointSlice over Endpoints #36673
Favor EndpointSlice over Endpoints #36673
Conversation
Helps with #14770 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
1b156ce
to
b12d675
Compare
/assign @robscott |
subsets: | ||
name: my-service-1 # by convention, use the name of the Service | ||
# as a prefix for the name of the EndpointSlice | ||
labels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we suggest to add the other label that indicates the owner?
LabelManagedBy = "endpointslice.kubernetes.io/managed-by"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 What would we set the value of that label to? The name of the user who is manually adding the EndpointSlice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm minded to suggest that documenting endpointslice.kubernetes.io/managed-by
here belongs as a separate change in its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sftim! Some great improvements here
content/en/docs/concepts/services-networking/endpoint-slices.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/services-networking/endpoint-slices.md
Outdated
Show resolved
Hide resolved
b12d675
to
379fa06
Compare
379fa06
to
7851fb2
Compare
Changes from the second forced push update the merge base to be level with main, without making other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sftim! One nit that is mostly unrelated to your changes but otherwise LGTM.
7851fb2
to
8f4d317
Compare
Document EndpointSlice as the preferred and most appropriate mechanism to record the backing endpoints of a Service. Co-authored-by: Rob Scott <rob.scott87@gmail.com> Co-authored-by: Shannon Kularathna <ax3shannonkularathna@gmail.com>
8f4d317
to
1eef742
Compare
Thanks @sftim! /lgtm |
LGTM label has been added. Git tree hash: eceea7275fca5587d58969106e5773530ea33037
|
/label refactor |
Not sure that #36673 (comment) worked |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Split out from #30817
Document EndpointSlice as the preferred and most appropriate mechanism to record the backing endpoints of a Service.
/sig network