Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor EndpointSlice over Endpoints #36673

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Sep 7, 2022

Split out from #30817

Document EndpointSlice as the preferred and most appropriate mechanism to record the backing endpoints of a Service.

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2022
@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

Helps with #14770

@netlify
Copy link

netlify bot commented Sep 7, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1eef742
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/634558289498e90009e0aa68
😎 Deploy Preview https://deploy-preview-36673--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim sftim force-pushed the 20220825_favor_endpointslices branch 3 times, most recently from 1b156ce to b12d675 Compare September 14, 2022 22:15
@aojea
Copy link
Member

aojea commented Sep 14, 2022

/assign @robscott

subsets:
name: my-service-1 # by convention, use the name of the Service
# as a prefix for the name of the EndpointSlice
labels:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we suggest to add the other label that indicates the owner?

	LabelManagedBy = "endpointslice.kubernetes.io/managed-by"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 What would we set the value of that label to? The name of the user who is manually adding the EndpointSlice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm minded to suggest that documenting endpointslice.kubernetes.io/managed-by here belongs as a separate change in its own PR.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sftim! Some great improvements here

@sftim sftim marked this pull request as draft September 23, 2022 08:37
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2022
@sftim sftim force-pushed the 20220825_favor_endpointslices branch from b12d675 to 379fa06 Compare October 2, 2022 16:03
@sftim sftim marked this pull request as ready for review October 2, 2022 16:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and davidopp October 2, 2022 16:03
@sftim sftim force-pushed the 20220825_favor_endpointslices branch from 379fa06 to 7851fb2 Compare October 2, 2022 16:04
@sftim
Copy link
Contributor Author

sftim commented Oct 2, 2022

Changes since last review

Changes from the second forced push update the merge base to be level with main, without making other changes.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sftim! One nit that is mostly unrelated to your changes but otherwise LGTM.

content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
@sftim sftim force-pushed the 20220825_favor_endpointslices branch from 7851fb2 to 8f4d317 Compare October 11, 2022 11:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Document EndpointSlice as the preferred and most appropriate mechanism
to record the backing endpoints of a Service.

Co-authored-by: Rob Scott <rob.scott87@gmail.com>
Co-authored-by: Shannon Kularathna <ax3shannonkularathna@gmail.com>
@sftim sftim force-pushed the 20220825_favor_endpointslices branch from 8f4d317 to 1eef742 Compare October 11, 2022 11:48
@robscott
Copy link
Member

Thanks @sftim!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eceea7275fca5587d58969106e5773530ea33037

@sftim
Copy link
Contributor Author

sftim commented Oct 11, 2022

@reylejano
Copy link
Member

/label refactor
/approve

@sftim
Copy link
Contributor Author

sftim commented Oct 19, 2022

Not sure that #36673 (comment) worked
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit ce7e330 into kubernetes:main Oct 19, 2022
@sftim sftim deleted the 20220825_favor_endpointslices branch October 22, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants