Avoid misleading text in Service concept #36672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/network
k8s-ci-robot
added
language/en
|
Helps with #14770 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
tengqm
reviewed
Sep 11, 2022
sftim
force-pushed
the
20220411_remove_misleading_service_clusterip_detail
branch
2 times, most recently
from
1377390 to
0f7f162
Compare
sftim
force-pushed
the
20220411_remove_misleading_service_clusterip_detail
branch
from
0f7f162 to
3b06176
Compare
chrisnegus
reviewed
Oct 11, 2022
The existing text implied that creating a node port or load balanced Service would actually add an extra Service object that you could see in the Kubernetes API. This isn't true, so avoid implying that it is.
sftim
force-pushed
the
20220411_remove_misleading_service_clusterip_detail
branch
from
3b06176 to
fdceaa2
Compare
sftim
commented
Oct 12, 2022
|
Also, would this change need tech review from SIG Network? |
|
Preview of updated page: I don't think this needs a tech review as the technical aspects changed or added in this PR are currently in the docs:
The changes look good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks Rey |
|
Looks good, thanks @sftim! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5dabd31c511de19a2f0985e301e9805cfb0d1201
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #30817
The existing text implied that creating a node port or load balanced Service would actually add an extra Service object that you could see in the Kubernetes API. This isn't true, so avoid implying that it is.
/sig network