Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Px 125 beta #34886

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Px 125 beta #34886

merged 1 commit into from
Aug 16, 2022

Conversation

trierra
Copy link
Contributor

@trierra trierra commented Jul 8, 2022 •
edited
Loading

Promote PortworxCSIMigration feature to Beta, off by default

KEP: kubernetes/enhancements#2589

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2022
@netlify
Copy link

netlify bot commented Jul 8, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit bea3222
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62e19b16839cbd0008e3a0ad

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 8, 2022
@trierra trierra mentioned this pull request Jul 12, 2022
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/es Issues or PRs related to Spanish language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 27, 2022
@trierra trierra marked this pull request as ready for review July 27, 2022 20:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@Sea-n
Copy link
Member

Sea-n commented Jul 31, 2022

/remove-area blog
/remove-language de es fr ja ko pl pt ru zh

@k8s-ci-robot k8s-ci-robot removed the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jul 31, 2022
@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language labels Jul 31, 2022
@xing-yang
Copy link
Contributor

/assign

@xing-yang
Copy link
Contributor

@trierra, there's another place that needs to be updated. See your previous PR for example:
https://github.com/kubernetes/website/pull/30445/files

@reylejano
Copy link
Member

/milestone 1.25
/assign @krol3
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 4, 2022
@sftim
Copy link
Contributor

sftim commented Aug 14, 2022

/retittle Update docs for PortworxCSIMigration feature graduation to beta

@sftim
Copy link
Contributor

sftim commented Aug 14, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Aug 14, 2022
sftim
sftim reviewed Aug 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. You also need to update https://kubernetes.io/docs/concepts/storage/volumes/#portworx-csi-migration

content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -85,6 +85,7 @@ different Kubernetes components.
| `CSIMigrationGCE` | `true` | Beta | 1.23 | |
| `CSIMigrationvSphere` | `false` | Beta | 1.19 | |
| `CSIMigrationPortworx` | `false` | Alpha | 1.23 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `CSIMigrationPortworx` | `false` | Alpha | 1.23 | |
| `CSIMigrationPortworx` | `false` | Alpha | 1.23 | 1.24 |

@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 553b4e5615ba1c0add5fee1b3a96fca2010e96c1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit be5bd9d into kubernetes:dev-1.25 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@gochist gochist Awaiting requested review from gochist

@bradtopol bradtopol Awaiting requested review from bradtopol

@jimangel jimangel Awaiting requested review from jimangel

@kcmartin kcmartin Awaiting requested review from kcmartin

Assignees

@xing-yang xing-yang

@krol3 krol3

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
7 participants
@trierra @Sea-n @xing-yang @reylejano @sftim @k8s-ci-robot @krol3