Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve troubleshooting guide for issues switching from Docker Engine #34764

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions content/en/docs/tasks/administer-cluster/cluster-upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ the documentation for the version of Kubernetes that you plan to upgrade to.

## Upgrade approaches

please go through [Urgent Upgrade Notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#urgent-upgrade-notes).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a couple of suggestions here.

  1. I'd recommend not using the word please here. 2. We're linking to the 1.24 upgrade notes for a particular reason right? We should say why we're asking our audience to go through the guide as a form of context setting.


### kubeadm {#upgrade-kubeadm}

If your cluster was deployed using the `kubeadm` tool, refer to
Expand Down
9 changes: 9 additions & 0 deletions content/en/docs/tasks/debug/debug-cluster/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,16 @@ This is an incomplete list of things that could go wrong, and how to adjust your
- Action: applications (containers) designed to tolerate unexpected restarts
- Mitigates: Node shutdown
- Mitigates: Kubelet software fault

### Things to note after dockershim migration
nitishfy marked this conversation as resolved.
Show resolved Hide resolved

## {{< note >}}
*Note: Due to change in CNI, the `kubelet` binary might not recognize `--network-plugin` flag even after passing to `kubelet` which leads to the following error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this could be phrased better. WDYT?

Suggested change
*Note: Due to change in CNI, the `kubelet` binary might not recognize `--network-plugin` flag even after passing to `kubelet` which leads to the following error:
*Note: Starting 1.24, since management of the CNI is no longer in scope for kubelet, the `--network-plugin` command line parameter has been removed from the binary and will throw the following error, if used:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @reylejano suggested here, I've omitted this line.


`Error: failed to parse kubelet flag: unknown flag: --network-plugin`

If you get the following error, go through the [Migrating from dockershim](/docs/tasks/administer-cluster/migrating-from-dockershim/) guide to get a better understanding of how to resolve this error.*
nitishfy marked this conversation as resolved.
Show resolved Hide resolved
## {{< note >}}

## {{% heading "whatsnext" %}}

Expand Down