Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Translate docs/concepts/workloads/controllers/job.md #34296

Merged
merged 110 commits into from
Aug 18, 2022
Merged

[ja] Translate docs/concepts/workloads/controllers/job.md #34296

merged 110 commits into from
Aug 18, 2022

Conversation

ziyi-xie
Copy link
Contributor

fix: #34170
This PR translates docs/concepts/workloads/controllers/job.md file into Japanese. Please let me know if there are any mistakes. Thank you !
/hold for Japanese developer's review.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 15, 2022
@k8s-ci-robot k8s-ci-robot requested a review from inductor June 15, 2022 04:58
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 15, 2022
@netlify
Copy link

netlify bot commented Jun 15, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f7a404a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f19cba7e052900085031d2
😎 Deploy Preview https://deploy-preview-34296--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ziyi-xie
Copy link
Contributor Author

/assign @atoato88 @t-inu
Hi! I translated the docs/concepts/workloads/controllers/job.md file into Japanese from line 1 to line 266 (That would be line 1 to line 470 in the Japanese version), would you mind checking if everything looks alright at your convenience time please?

@nasa9084
Copy link
Member

@atoato88 and @t-inu are not approver for Japanese document. Although you can assign them but they cannot approve the PRs for the Japanese website, so you need to assign me or @inductor .
If you want to get reviewed by them, you can cc them as reviewers.

/cc @atoato88 @t-inu
/assign @nasa9084

And if this PR is ready for review, you do not need to /hold this PR
(let me unhold this PR because it seems that this PR is ready for review, right?)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot requested review from atoato88 and t-inu June 15, 2022 14:50
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed ~L306

content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@atoato88
Copy link
Contributor

Thank you to mention me.
I'll review this PR as reviewer.

@atoato88
Copy link
Contributor

I reviewed up to here( - L353)

@ziyi-xie
Copy link
Contributor Author

@atoato88 and @t-inu are not approver for Japanese document. Although you can assign them but they cannot approve the PRs for the Japanese website, so you need to assign me or @inductor . If you want to get reviewed by them, you can cc them as reviewers.

/cc @atoato88 @t-inu /assign @nasa9084

And if this PR is ready for review, you do not need to /hold this PR (let me unhold this PR because it seems that this PR is ready for review, right?) /unhold

@nasa9084 Well noted and thank you so much for your kind instruction about how to assign a reviewer!
And about the hold command, since I only translated about 30% of this file and currently working on the rest of it, I think this PR is ready for review but not for merge. Is there any other command to show this kind of information clearly?

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle [WIP][ja] Translate docs/concepts/workloads/controllers/job.md

content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot changed the title Translate docs/concepts/workloads/controllers/job.md into Japanese [WIP][ja] Translate docs/concepts/workloads/controllers/job.md Jun 16, 2022
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Aug 8, 2022

@atoato88 @t-inu Thank you so much for your kind instructions! All the comments have been addressed and I really learned a lot during this whole process.

@atoato88
Copy link
Contributor

/lgtm
Great work! 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e69b84b242d299e10a84960d62dedd57afa0a02b

@t-inu
Copy link
Member

t-inu commented Aug 15, 2022

LGTM
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 15, 2022
@atoato88
Copy link
Contributor

@nasa9084
I think this PR is ready to merge.
Could you review this?

@nasa9084
Copy link
Member

sorry to be late
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9041424 into kubernetes:main Aug 18, 2022
@atoato88
Copy link
Contributor

Thank you for approving, we have completed tough work. 🎉

@ziyi-xie
Copy link
Contributor Author

@atoato88 @t-inu @nasa9084 @Sea-n Thanks again for your kind instructions! I really appreciate all your help.

@ziyi-xie ziyi-xie deleted the update-ja branch August 25, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate docs/concepts/workloads/controllers/job.md into Japanese
6 participants