Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Kubernetes 1.24 Release Blog Article #32867

Merged
merged 58 commits into from
May 3, 2022
Merged

Create Kubernetes 1.24 Release Blog Article #32867

merged 58 commits into from
May 3, 2022

Conversation

mickeyboxell
Copy link
Contributor

@mickeyboxell mickeyboxell commented Apr 12, 2022 •
edited
Loading

Creating a PR for the Kubernetes 1.24 release blog.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 12, 2022
@netlify
Copy link

netlify bot commented Apr 12, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit d1aa9e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/627030654501d400089c7713
😎 Deploy Preview https://deploy-preview-32867--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback.

content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more early feedback.

content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2022
katcosgrove and others added 8 commits April 26, 2022 14:32
@katcosgrove @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
57469c7 
Co-authored-by: Tim Bannister <[email protected]>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
1db68a3 
Co-authored-by: Tim Bannister <[email protected]>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
c31cf22 
Co-authored-by: Tim Bannister <[email protected]>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
f6fe74c 
Co-authored-by: Tim Bannister <[email protected]>
@mickeyboxell @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
13cbb86 
Co-authored-by: Tim Bannister <[email protected]>
@mickeyboxell @sftim
Update content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md
fb6ca17 
Co-authored-by: Tim Bannister <[email protected]>
@mickeyboxell
Update 2022-4-26-kubernetes-release-1.24.md
ed421d6 
Added additional major themes (more changes to this section are expected) along with user highlights.
@mickeyboxell
Update 2022-4-26-kubernetes-release-1.24.md
b84e611 
Added release name
@mickeyboxell
Update 2022-4-26-kubernetes-release-1.24.md
e1eb254 
Removing cri-dockerd from the list of impacted CNI runtimes.
sftim
sftim reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general nit: we usually write headings in sentence case.

content/en/blog/_posts/2022-4-26-kubernetes-release-1.24.md Outdated Show resolved Hide resolved
@nate-double-u
Copy link
Contributor

/hold
so we don't merged early

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
mickeyboxell and others added 10 commits May 2, 2022 12:25
@mickeyboxell
Updated release webinar link
c9be690
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
a889e49 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
1fde153 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
3766319 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
745308c 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
7c52bd5 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
eb115a8 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
ad677c3 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
b96d7cb 
Co-authored-by: Nate W. <[email protected]>
@mickeyboxell @nate-double-u
Update content/en/blog/_posts/2022-05-03-kubernetes-release-1.24.md
d1aa9e6 
Co-authored-by: Nate W. <[email protected]>
@sftim
Copy link
Contributor

sftim commented May 2, 2022

/retitle Create Kubernetes 1.24 Release Blog Article

@k8s-ci-robot k8s-ci-robot changed the title Create 2022-5-03-kubernetes-release-1.24.md Create Kubernetes 1.24 Release Blog Article May 2, 2022
@sftim
Copy link
Contributor

sftim commented May 2, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 2, 2022
@sftim
Copy link
Contributor

sftim commented May 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JamesLaverack, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@sftim
Copy link
Contributor

sftim commented May 2, 2022

@mickeyboxell if you can, edit the PR description to omit the word “placeholder”

@nate-double-u
Copy link
Contributor

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2022
@nate-double-u nate-double-u merged commit fe7628e into kubernetes:main May 3, 2022
@Sea-n
Copy link
Member

Sea-n commented Jun 7, 2022

Hey @nate-double-u, are there any reason to merge this PR by hand instead of let @k8s-ci-robot do this automatically?

This PR have 58 commits, and it was able to be squashed by @k8s-ci-robot. 🙁

@sftim
Copy link
Contributor

sftim commented Jun 7, 2022

(I'm a blog editor).

This was published during a repository freeze.

It would be useful to have done a final squash before merge. I would not recommend using auto-squash during that part of the release process.
@Sea-n, if you'd like to know what the commit that aggregates the changes from this PR would look like, folks can help you work that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AuraSinis AuraSinis AuraSinis left review comments

@sftim sftim sftim left review comments

@nate-double-u nate-double-u nate-double-u left review comments

@JamesLaverack JamesLaverack JamesLaverack approved these changes

@matglas matglas matglas left review comments

@craigbox craigbox craigbox left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@JamesLaverack JamesLaverack

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.