-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1753 Deprecate Kubernetes system components logs sanitization #32473
Conversation
Signed-off-by: Parul <[email protected]>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
Welcome @husky-parul! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
for SIG Instrumentation
do we need to remove any other instances of e.g. the command line flag in component docs?
LGTM label has been added. Git tree hash: 7dbacf138eb949410f3d2f024d699c77e60efecf
|
A quick search shows the |
@kubernetes/sig-docs-en-reviews Please have some insights on this! |
I asked about that in one of my previous PRs and was told that those other pages are indeed auto-generated and do not need to be edited. Therefore this PR here should be complete. Can we merge it? I need to make further changes to that page. /assign @savitharaghunathan For approval. |
@husky-parul : please remove the draft flag. |
enhancement ref: kubernetes/enhancements#1753 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nate-double-u The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Placeholder PR for updating the website documentation to remove references to the Kubernetes system components logs sanitization feature. The proposal for the deprecation of the feature was discussed at SIG Instrumentation and ack from SIG Security: https://groups.google.com/g/kubernetes-dev/c/xhQuwdd2Smw/m/L_EyHKbDAAAJ