Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1753 Deprecate Kubernetes system components logs sanitization #32473

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

husky-parul
Copy link
Contributor

Placeholder PR for updating the website documentation to remove references to the Kubernetes system components logs sanitization feature. The proposal for the deprecation of the feature was discussed at SIG Instrumentation and ack from SIG Security: https://groups.google.com/g/kubernetes-dev/c/xhQuwdd2Smw/m/L_EyHKbDAAAJ

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 870d126
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/623cb65147193a00096d0a99

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @husky-parul!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 24, 2022
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
for SIG Instrumentation

do we need to remove any other instances of e.g. the command line flag in component docs?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7dbacf138eb949410f3d2f024d699c77e60efecf

@chrisnegus
Copy link
Contributor

A quick search shows the experimental-logging-sanitization flag showing up in these files in the command-line-tools-reference: kube-controller-manager.md, kube-scheduler.md, and kube-apiserver.md. I believe they are auto-generated, but I'm not sure if the feature docs just go away when the related feature is removed. Maybe someone from sig-docs can provide some insight.

@mehabhalodiya
Copy link
Contributor

@kubernetes/sig-docs-en-reviews Please have some insights on this!

@pohly
Copy link
Contributor

pohly commented Apr 4, 2022

A quick search shows the experimental-logging-sanitization flag showing up in these files in the command-line-tools-reference: kube-controller-manager.md, kube-scheduler.md, and kube-apiserver.md. I believe they are auto-generated, but I'm not sure if the feature docs just go away when the related feature is removed. Maybe someone from sig-docs can provide some insight.

I asked about that in one of my previous PRs and was told that those other pages are indeed auto-generated and do not need to be edited. Therefore this PR here should be complete. Can we merge it? I need to make further changes to that page.

/assign @savitharaghunathan

For approval.

@pohly
Copy link
Contributor

pohly commented Apr 4, 2022

@husky-parul : please remove the draft flag.

@husky-parul husky-parul marked this pull request as ready for review April 4, 2022 16:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022
@husky-parul husky-parul changed the title [placeholder] KEP-1753 Deprecate Kubernetes system components logs sanitization KEP-1753 Deprecate Kubernetes system components logs sanitization Apr 4, 2022
@mehabhalodiya
Copy link
Contributor

enhancement ref: kubernetes/enhancements#1753
/assign @chrisnegus
/sig instrumentation

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Apr 4, 2022
Copy link
Contributor

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nate-double-u
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0c9f2ff into kubernetes:dev-1.24 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants