Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark user-space kube-proxy as deprecated #32468

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

PriyanshuAhlawat
Copy link
Contributor

This pr marks the kube-proxy in userspace mode as deprecated.
closes #32421

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim March 24, 2022 12:28
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 24, 2022
@sftim
Copy link
Contributor

sftim commented Mar 24, 2022

/retitle Mark user-space kube-proxy as deprecated

/sig network

@k8s-ci-robot k8s-ci-robot changed the title Update service.md Mark user-space kube-proxy as deprecated Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 70574cf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/623d9fccc0d26500093f3bbe
😎 Deploy Preview https://deploy-preview-32468--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim previously requested changes Mar 24, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this shortcode to mark things as deprecated @PriyanshuAhlawat

{{< feature-state for_k8s_version="v1.xx" state="deprecated" >}}

By convention, we put this shortcode immediately after the relevant heading.

PS. You have also made some unrelated whitespace changes. I recommend not making those changes in this PR; if you did make that kind of change, it should happen in its own commit.

You can use git add -p or your IDEs equivalent command to only stage specific changes.

@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebeb25b262154946bc6037868d2561fbf5cbb11b

@sftim sftim dismissed their stale review March 25, 2022 13:02

Some feedback incorporated

@sftim
Copy link
Contributor

sftim commented Mar 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit c883ec3 into kubernetes:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-proxy userspace mode is deprecated
4 participants